A few cli commands are still using amino or couldn't be easily migrated to use the proto pathway. These were discovered and flagged in #6859. Migrate them to use proto.
GetCmdSubmitProposal -> ParseCommunityPoolSpendProposalJSON #7244 NewWithdrawAllRewardsCmd #7244 Any) /cc @fedekunze client.Context.PrintOutputLegacy (from #6999)@anilCSE @aaronc can you paste an example blob of how the output for the IBC queries looks like? We can tackle it this week
I don't have IBC test data to do that @fedekunze. Once #6999 is done, you just need to try to use PrintOutput instead of PrintOutputLegacy and you'll see the errors.
@alexanderbez QueryTxsByEvents uses TxSearch from tendermint which uses slightly different pagination. This causes some inconsistency in queries using this. https://github.com/cosmos/cosmos-sdk/blob/20c80cfd44a068a592148d648c50de3459fd6295/x/auth/client/query.go#L46
One option I can think of is fetch all data, and paginate in sdk to act similar to other queries. Any thoughs?
cc @aaronc @anilCSE
I would honestly opt to use Tendermint's pagination when it comes to tx searching. I don't think getting all txs behind the scenes is a good strategy.
@anilCSE can you provide a written update for this issue here?
Most helpful comment
I would honestly opt to use Tendermint's pagination when it comes to tx searching. I don't think getting all txs behind the scenes is a good strategy.