Cosmos-sdk: Enforce ICS 20 (transfer) to only use UNORDERED channels

Created on 6 Aug 2020  路  6Comments  路  Source: cosmos/cosmos-sdk

Ref https://github.com/cosmos/ics/issues/463, spec changes have been made upstream in https://github.com/cosmos/ics/commit/6280b5357d761b7b515a209a93c17eb52e81a77e.

good first issue ibc
Source
picture cwgoes

Most helpful comment

Hi, can I work on this?

picture dauTT on 8 Aug 2020
❤3

All 6 comments

this was never implemented, but we do need to enforce that the ordering is UNORDERED it seems this was never done since the relayer didn't support UNORDERED channels yet

colin-axner picture colin-axner on 7 Aug 2020

If this was never implemented, we should check that the channel is UNORDERED at least.

cwgoes picture cwgoes on 7 Aug 2020
👍1

The ChanOpen callbacks need to match the ICS20 spec. A check that the channel type is UNORDERED needs to be added.

colin-axner picture colin-axner on 7 Aug 2020

Yes, this is listed as a TODO

I guess we will have to do some major upgrades to the relayers soon for this to do live with unordered channels?

ethanfrey picture ethanfrey on 7 Aug 2020
👍1

Hi, can I work on this?

dauTT picture dauTT on 8 Aug 2020
❤3

@dauTT yup! Go for it :+1:

colin-axner picture colin-axner on 8 Aug 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jackzampolin picture jackzampolin  路  3Comments
cwgoes picture cwgoes  路  3Comments
rigelrozanski picture rigelrozanski  路  3Comments
adrianbrink picture adrianbrink  路  3Comments
ValarDragon picture ValarDragon  路  3Comments