Cosmos-sdk: Finish migration to grpc in IBC

Created on 6 Aug 2020  Â·  5Comments  Â·  Source: cosmos/cosmos-sdk

Summary

Now that client state and consensus states have been migrated to proto, the querier in IBC should be removed and the client/consensus state grpc functions should be added.


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned
ibc

Most helpful comment

opened #7036

All 5 comments

Also, sounds like we need to figure out how proofs will work with gRPC queries/queriers.

So for the short term I'm going to add a ABCI query helper func similar to the one in the testing package to ensure the +1 only happens once. I'll probably do a pr which renames client/utils to client/query with query.go. This file will contain functions that basically act as a wrapper around gRPC calls and use the helper func to inject a proof/proof height into the queries.

I think it is quite redundant to do a gRPC query and an ABCI query in the same call, so I will also open issue around my thoughts on how to handle adding proofs from within gRPC calls and at least get the conversation started around this issue. Though it isn't strictly necessary for 1.0 so I think its implementation is not high priority unless it seems to be relatively easy

cc/ @fedekunze @AdityaSripal

opened #7036

Unrelated to the comment above, but I think we should drop the support for the legacy REST server and just use gRPC + gateway for REST-like queries.

Unrelated to the comment above, but I think we should drop the support for the legacy REST server and just use gRPC + gateway for REST-like queries.

I agree :+1:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ValarDragon picture ValarDragon  Â·  3Comments

fedekunze picture fedekunze  Â·  3Comments

johnmcdowall picture johnmcdowall  Â·  3Comments

rigelrozanski picture rigelrozanski  Â·  3Comments

ValarDragon picture ValarDragon  Â·  3Comments