Cosmos-sdk: Disable protobuf lint on third party proto files

Created on 4 Aug 2020  Â·  2Comments  Â·  Source: cosmos/cosmos-sdk

Summary

I noticed #6926 adding the ics23 proto file causes the protobuf lint to break. I think we should update the protobuf lint to exclude certain proto files.

Problem Definition

We are importing third_party proto files that are not guaranteed to be properly linted. The test will break and no longer be useful.

Proposal

Lint our own proto files and maybe third party proto files we have control over


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

Most helpful comment

https://github.com/cosmos/cosmos-sdk/blob/4e73e0f817b3e9ab75937c705fb49c6e5ae99eb0/buf.yaml#L17-L20 to something like:

ignore:
  - third_party/proto 

should do the trick and we shouldn't have to keep updating the list

All 2 comments

I think we just need to update the buf configuration here?

https://github.com/cosmos/cosmos-sdk/blob/4e73e0f817b3e9ab75937c705fb49c6e5ae99eb0/buf.yaml#L17-L20 to something like:

ignore:
  - third_party/proto 

should do the trick and we shouldn't have to keep updating the list

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hendrikhofstadt picture hendrikhofstadt  Â·  3Comments

fedekunze picture fedekunze  Â·  3Comments

ValarDragon picture ValarDragon  Â·  3Comments

mossid picture mossid  Â·  3Comments

ValarDragon picture ValarDragon  Â·  3Comments