Cosmos-sdk: Consider allowing empty version strings

Created on 23 Jul 2020  路  4Comments  路  Source: cosmos/cosmos-sdk

The ICS specifications do not prohibit empty version strings for channels, but the SDK does - any reason why? Empty versions are safe, as long as they are agreed upon.

good first issue help wanted ibc
Source
picture cwgoes
👍1

Most helpful comment

Hi, can I work on this?

picture dauTT on 30 Jul 2020
👍2

All 4 comments

ah, I didn't know they were valid. I guess I'm used to rejecting empty strings on the validation functions. We can change it 馃憤

fedekunze picture fedekunze on 23 Jul 2020
👍2

Hi, can I work on this?

dauTT picture dauTT on 30 Jul 2020
👍2

Thanks @dauTT. Ping me if you need any guidance

fedekunze picture fedekunze on 30 Jul 2020

We should re-open this issue, because we missed to remove this piece of code:

image

dauTT picture dauTT on 31 Jul 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ValarDragon picture ValarDragon  路  3Comments
ValarDragon picture ValarDragon  路  3Comments
kevlubkcm picture kevlubkcm  路  3Comments
ValarDragon picture ValarDragon  路  3Comments
hendrikhofstadt picture hendrikhofstadt  路  3Comments