Cosmos-sdk: CLI Refactor

[alexanderbez]

Summary

The current state of the CLI in the SDK is a bit of a mess, with the use of Viper global/singleton, ad-hoc flag instantiation and binding, and magically instantiation of client.Context. It makes testing difficult and runtime errors hard to debug.

Proposal

Once https://github.com/cosmos/cosmos-sdk/issues/6423 is finalized and merged, we'll have the ability to remove a lot of the existing cruft from the CLI framework. Namely, we should:

• [x] Combine the CLI into a single binary (WIP)
• [x] Remove use of Viper and Viper flag binding (build upon https://github.com/cosmos/cosmos-sdk/pull/6572)
  
  
  
  • [x] app/server - https://github.com/cosmos/cosmos-sdk/pull/6599
  
  
  • [x] keys - https://github.com/cosmos/cosmos-sdk/pull/6613
  
  
  • [x] x/auth - https://github.com/cosmos/cosmos-sdk/pull/6609
  
  
  • [x] x/bank
  
  
  • [x] x/genutil - https://github.com/cosmos/cosmos-sdk/pull/6596
  
  
  • [x] x/crisis
  
  
  • [x] x/distribution - https://github.com/cosmos/cosmos-sdk/pull/6604
  
  
  • [x] x/evidence - https://github.com/cosmos/cosmos-sdk/pull/6604
  
  
  • [x] x/genaccounts
  
  
  • [x] x/gov - https://github.com/cosmos/cosmos-sdk/pull/6604
  
  
  • [x] x/ibc - https://github.com/cosmos/cosmos-sdk/pull/6608
  
  
  • [x] x/ibc-transfer - https://github.com/cosmos/cosmos-sdk/pull/6608
  
  
  • [x] x/mint
  
  
  • [x] x/params
  
  
  • [x] x/slashing
  
  
  • [x] x/staking - https://github.com/cosmos/cosmos-sdk/pull/6631
  
  
  • [x] version - https://github.com/cosmos/cosmos-sdk/pull/6628
  
  
  • [x] x/upgrade - https://github.com/cosmos/cosmos-sdk/pull/6604
  
  
• [x] Remove fixtures
• [x] Remove client.Context Init* and New* functions - https://github.com/cosmos/cosmos-sdk/pull/6797

Stretch Goal:

• [ ] Support --config flag where if provided, any field found will set/override any flag/arg.

/cc @aaronc @anilCSE @sahith-narahari @alessio

---

For Admin Use

• [ ] Not duplicate issue
• [ ] Appropriate labels applied
• [ ] Appropriate contributors tagged
• [ ] Contributor assigned/self-assigned

[colin-axner]

Since this is a quite a big change. Could we add creating a doc to the to do list for this. Maybe as an upgrade doc or explaining the scope of the changes for projects dependent upon this area of code.

[alexanderbez]

@colin-axner sure, but the only major differences from a UX POV are:

1. the removal of config.toml
2. a single binary
3. in process API

We'll have an upgrading doc that will cover all of this stuff.

[ethanfrey]

Great job bez!

Looking forward to the new cli