Cosmos-sdk: Change blacklist naming

[colin-axner]

Summary

Change blacklist to a neutral term that suggests its function without further reading.

Problem Definition

The function of blacklisted accounts was added as a fix to prevent module supply invariants from breaking during the lifetime of the chain. While the term does have popular usage in the computer science world, it is not neutral ("whitelist/blacklist") and can have negative connotations whether or not it was originally intended to. Furthermore, I find the usage vague in reference to the exact restrictions placed on a module account address.

Proposal

I don't have a replacement term in mind, but it should reference the specific characteristic that module accounts cannot be sent to. Maybe something like DisableRecvList/DenyRecvList or CannotSendToList

---

For Admin Use

• [ ] Not duplicate issue
• [ ] Appropriate labels applied
• [ ] Appropriate contributors tagged
• [ ] Contributor assigned/self-assigned

[alexanderbez]

You have my full support in this regard. Should be a trivial thing to tackle 👍

[aaronc]

See https://github.com/golang/go/commit/608cdcaede1e7133dc994b5e8894272c2dce744b and https://github.com/golang/go/commit/2cd2ff6f564dce5be0c4fb7f06338ff7af3fc9a9 for details on the naming golang has adopted. We should likely follow these conventions.