Cosmos-sdk: This should use len of Signers, the error message is wrong

Created on 18 May 2020  路  3Comments  路  Source: cosmos/cosmos-sdk

https://github.com/cosmos/cosmos-sdk/blob/3dcdc582afee14af0e7691aee61f70adbe3a2016/std/tx.go#L101

should be,

sdkerrors.ErrUnauthorized, "wrong number of signers; expected %d, got %d", len(tx.GetSigners()), len(stdSigs),
good first issue help wanted

Most helpful comment

Hi, happy to fix this one.

All 3 comments

Hi, happy to fix this one.

Against which branch should I submit the PR?
master branch is not the correct one:

https://github.com/cosmos/cosmos-sdk/tree/master/std

but the contribution guideline is misleading:

https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#updating-documentation

  1. Follow standard Github best practices: fork the repo, branch from the HEAD of master, make some commits, and submit a PR to master

hey it seems this was moved here https://github.com/cosmos/cosmos-sdk/blob/master/x/auth/types/stdtx.go#L189. and yes you can open against master.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jackzampolin picture jackzampolin  路  3Comments

kevlubkcm picture kevlubkcm  路  3Comments

ValarDragon picture ValarDragon  路  3Comments

fedekunze picture fedekunze  路  3Comments

rigelrozanski picture rigelrozanski  路  3Comments