Cosmos-sdk: Packet timeout height should be compared with local consensus height

Created on 2 Jan 2020  路  5Comments  路  Source: cosmos/cosmos-sdk

0cc893b8-5aee-4249-be3e-a2be0ddcaddb

(reported via Telegram)

cc @fedekunze

bug good first issue ibc

All 5 comments

I would like to give it a try tomorrow. Is there any details about?

I would like to give it a try tomorrow. Is there any details about?

That would be fantastic! The local height (ctx.BlockHeight() I believe) should be used instead.

Closed via #5462. Sorry @PumpkinSeed I didn't notice you wanted to work on it. Do you want to contribute to the IBC implementation (ibc-alpha branch)? One thing that's missing is increasing the code coverage with unit tests (especially on the xibc/<XX-XXX>/types directories). That should give you a high-level understanding of the core components of the protocol.

Do you want to contribute to the IBC implementation (ibc-alpha branch)? One thing that's missing is increasing the code coverage with unit tests (especially on the xibc/<XX-XXX>/types directories). That should give you a high-level understanding of the core components of the protocol.

Yes. Just to avoid misunderstands, can you tell me which issue belongs to it?

5470 @PumpkinSeed

Was this page helpful?
0 / 5 - 0 ratings