Cosmos-sdk: ICS 06: Solo machine client

[fedekunze]

Implement ICS 06 spec

Ref: https://github.com/cosmos/ics/pull/331

---

For Admin Use

• [ ] Not duplicate issue
• [ ] Appropriate labels applied
• [ ] Appropriate contributors tagged
• [ ] Contributor assigned/self-assigned

[jackzampolin]

I don't think this blocks anything, but I know the Agoric folks might want this.

[cwgoes]

This does not block 1.0

[fedekunze]

@colin-axner do you want to tackle this next week?

[colin-axner]

@fedekunze yup I can do it

[colin-axner]

What type should the public key be? Should it be the tm crypto like x/auth uses? Also, I'm assuming the signature can just be []byte

[cwgoes]

What type should the public key be? Should it be the tm crypto like x/auth uses? Also, I'm assuming the signature can just be []byte

That sounds fine for now.

[colin-axner]

All verification functions require the sequence to be incremented after being called. This is not possible given the current client_state interfaces which just return error and not any way to update client state.

I think either the spec or the verification function interfaces need to be modified to account for this. Any ideas on what the course of action should be?

[cwgoes]

All verification functions require the sequence to be incremented after being called. This is not possible given the current client_state interfaces which just return error and not any way to update client state.
I think either the spec or the verification function interfaces need to be modified to account for this. Any ideas on what the course of action should be?

The verification functions need to be able to alter the client state - in this case, replay prevention & ordering control is achieved by incrementing the sequence each time (in a Tendermint light client, these are achieved with ordered headers, but with a solo machine we don't have those).

I think we'll need to modify the SDK code to allow for state modification in the verifyXYZ functions.

[colin-axner]

I opened an issue to resolve modification of client state for verification functions #6188

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.