Cosmos-sdk: Support Pagination for Governance Votes

Created on 29 Nov 2019  ·  4Comments  ·  Source: cosmos/cosmos-sdk

Summary

Support pagination for /gov/{proposalID}/votes. The pagination should support not only the querier but also the tx event query (i.e. pagination should be proxied to the tx event query).

ref: https://github.com/cosmos/cosmos-sdk/issues/5212


For Admin Use

  • [x] Not duplicate issue
  • [x] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned
REST good first issue gov

Most helpful comment

hey @alexanderbez . do you want to work on this one yourself? or it is free to take? I am looking for a places to contribute, and perhaps can help with this one

All 4 comments

hey @alexanderbez . do you want to work on this one yourself? or it is free to take? I am looking for a places to contribute, and perhaps can help with this one

Please @dshulyak, would love any contribution here! Let me know if you have any questions. It should be pretty straightforward -- see other pagination handlers for example :)

@alexanderbez does it make sense to add pagination support for Deposits as well?

@dshulyak yes, I believe we'll need the same for deposits 👍

Was this page helpful?
0 / 5 - 0 ratings