Cosmos-sdk: Specs Updates

Created on 26 Jun 2019  ·  5Comments  ·  Source: cosmos/cosmos-sdk

Summary

Specs are very outdated and currently don't reflect the current status of the code. Also, not all of them follow the standard defined in SPEC-SPEC.md.

Proposal

Some of the specs that need to be updated:

  • [ ] Auth: re/move keepers file, define AnteHandler on concepts, etc
  • [ ] Bank: re/move keepers file, update msgs, missing concepts, etc
  • [ ] Staking: missing slashing section
  • [ ] Distribution : Update state and keys
  • [ ] Gov : Add new proposal types, update state
  • [ ] Slashing : move Tombstone concepts

Note: this list not final. Feel free to create an issue for each item or update it.

cc: @alexanderbez @jackzampolin


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned
good first issue meta-issue pinned spec

Most helpful comment

I would recommend updating the shortcomings section of the distribution spec. It’s unclear from reading it which of the concerns outlined are outdated now that F1 has been implemented and which are still relevant. For example #2764 is linked in that section, but has since been closed.

All 5 comments

Thanks @fedekunze!

Yup just noticed some missing stuff in distribution 👍

I would recommend updating the shortcomings section of the distribution spec. It’s unclear from reading it which of the concerns outlined are outdated now that F1 has been implemented and which are still relevant. For example #2764 is linked in that section, but has since been closed.

In the gov spec it says that proposals are executed immediately if 2/3 of InitTotalVotingPower votes yes. This isn't implemented and should be removed.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rigelrozanski picture rigelrozanski  ·  3Comments

faboweb picture faboweb  ·  3Comments

kevlubkcm picture kevlubkcm  ·  3Comments

cwgoes picture cwgoes  ·  3Comments

cwgoes picture cwgoes  ·  3Comments