Cosmos-sdk: Add ability to set source of transactions for clients

Created on 29 Apr 2019  Â·  8Comments  Â·  Source: cosmos/cosmos-sdk

Summary

from @fedekunze

ultimately we should maybe have another mean on the SDK (could be another optional tx tag) to search and query for transactions made from a specific client.

Problem Definition


Right now, some clients are using the memo field which is unsatisfactory because of how some exchanges require their users to use this field.

Lunie was previously (mis)using the memo field by including a "Sent from Lunie" message so in the future we could have some data about our contribution to the network.

This should also be considered in the context of #1136 - as this will likely require a way to track individual client contributions.


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned
proposal stale

Most helpful comment

One of the reasons I am in favor on #1136 is that we can keep the per tx tag to be 1-4 bytes in size rather than 20byte address by having on chain registry that maps sources to addresses

All 8 comments

Thanks @jbibla. So if I'm reading this correctly, what you're asking for is the ability to query for txs by sender/source where this sender/source is not necessarily a bech32 address, but some ASCII text (e.g. "sent from XYZ")? Is this correct?

One way would to be indeed tag the memo. Perhaps there is an alternative too.

yeah that sound about right. is "tagging the memo" something we could do right now? if so, that might suffice.

thinking more broadly and in the context of #1136 it might be nice to have some kind of client ID / hash instead of text.

but the goal, for us, right now is just to be able to query transaction on the hub where the source was lunie. until now, we've been using the memo field but this has been an issue for some of our users.

i'm sure you have better ideas for how to do this efficiently and effectively.

is "tagging the memo" something we could do right now? if so, that might suffice.

Yes, we can accomplish this pretty easily in fact.

but the goal, for us, right now is just to be able to query transaction on the hub where the source was lunie. so far we've been using the memo field.

I believe that's the purpose of memo and we should stick to using that -- it provides great flexibility.

Maybe (?) relevant for this discussion: #1136

Indeed relevant but we'd still need to add a tag based on either the memo or a new field if a proposal based on #1136 passes.

One of the reasons I am in favor on #1136 is that we can keep the per tx tag to be 1-4 bytes in size rather than 20byte address by having on chain registry that maps sources to addresses

Agreed @zmanian

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ValarDragon picture ValarDragon  Â·  3Comments

mossid picture mossid  Â·  3Comments

johnmcdowall picture johnmcdowall  Â·  3Comments

kevlubkcm picture kevlubkcm  Â·  3Comments

rigelrozanski picture rigelrozanski  Â·  3Comments