Cosmos-sdk: Release v0.34.2 Wishlist

[alexanderbez]

(non-state-machine breaking) Items that are desired to be included in the v0.34.2 patch release:

• [x] https://github.com/cosmos/cosmos-sdk/pull/4182
• [x] https://github.com/cosmos/cosmos-sdk/pull/4181
• [x] https://github.com/cosmos/cosmos-sdk/pull/4183

Once the above are merged, PRs using the release/v0.34.2 branch will be opened up against develop and master. During the merge to develop, some pending log entries will have to be removed.

/cc @jackzampolin @zmanian

---

For Admin Use

• [ ] Not duplicate issue
• [ ] Appropriate labels applied
• [ ] Appropriate contributors tagged
• [ ] Contributor assigned/self-assigned

[jackzampolin]

Does this want to include: https://github.com/cosmos/cosmos-sdk/issues/4172?

Looks good otherwise!

[fedekunze]

agree, we should definitely include #4172

[alexanderbez]

4172 is already fixed by #4135.

[faboweb]

When is the release scheduled? If not today, could you do a release with #4135 and release more changes with another patch?

[alexanderbez]

@faboweb yes, #4135 is already in this wishlist. The patch release will be out this week.

[faboweb]

Hm ok. Just saying that in the meantime users can't delegate with Lunie.

[alexanderbez]

I see no need to rush just for that. In fact, the issue you're running into w/ Lunie is because you're sending txs with mode=block which btw is __not__ recommended -- they should be sent with mode=sync and have the tx hash displayed, where eventually it shows if the tx is included in a block or fails (eg. how etherscan.io works).

[gamarin2]

I think a querier for total supply is really needed

[alexanderbez]

@gamarin2 sure, but the purpose of this patch release is to only include what is necessary. Total supply would be a great addition, but (1) it's still a WIP, (2) could potentially be state-machine-breaking, and (3) would hinder the timely release of this as it would need to be thoroughly tested.

[gamarin2]

Ok sure! Just saying that if we can get that in a non-breaking release, we should do it as soon as possible! :)

[fedekunze]

they should be sent with mode=sync and have the tx hash displayed, where eventually it shows if the tx is included in a block or fails (eg. how etherscan.io works).

@faboweb @jbibla can you double check if this solution works? If it doesn't, I'm in favor of releasing a patch with #4135