Cosmos-sdk: governance bonded tokens should be sdk.Int

Created on 31 Jan 2019  路  4Comments  路  Source: cosmos/cosmos-sdk

Currently a relic of decimal power:
BondedTokens within validatorGovInfo of governance should be converted to using sdk.Int

api-breaking gov
Source
picture rigelrozanski
👍1

Most helpful comment

meh this is a minor PR which makes it our system more correct - will save future effort/prevent bugs - so this is prudent to take on soon

picture rigelrozanski on 1 Feb 2019
👍2

All 4 comments

Hmm, should we do this now? Could they ever be non-integral?

cwgoes picture cwgoes on 31 Jan 2019

no they can't - we should do this asap. will do as another PR

rigelrozanski picture rigelrozanski on 31 Jan 2019
👍1

Does this really need to be #prelaunch? Can we push this later?

jackzampolin picture jackzampolin on 1 Feb 2019

meh this is a minor PR which makes it our system more correct - will save future effort/prevent bugs - so this is prudent to take on soon

rigelrozanski picture rigelrozanski on 1 Feb 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ValarDragon picture ValarDragon  路  3Comments
ValarDragon picture ValarDragon  路  3Comments
rigelrozanski picture rigelrozanski  路  3Comments
rigelrozanski picture rigelrozanski  路  3Comments
faboweb picture faboweb  路  3Comments