Cosmos-sdk: Remove use of bechValidator

Created on 4 Jan 2019  路  5Comments  路  Source: cosmos/cosmos-sdk

Within x/stake/types/validator.go type bechValidator is defined. I'm not sure we still require that type based on updates to address and pubkey types... requires more investigation though

CC @alexanderbez @sunnya97

code-hygiene staking
Source
picture rigelrozanski

Most helpful comment

we don't need it now that amino parses all the responses (for the API requests) to bech32

picture fedekunze on 4 Jan 2019
👍2

All 5 comments

we don't need it now that amino parses all the responses (for the API requests) to bech32

fedekunze picture fedekunze on 4 Jan 2019
👍2

Yeah I don't think we need it @rigelrozanski 馃憤

alexanderbez picture alexanderbez on 4 Jan 2019
😄1

awesome

rigelrozanski picture rigelrozanski on 4 Jan 2019

I think we have addressed this. Closing.

jackzampolin picture jackzampolin on 28 May 2019

the struct is still on x/staking/validator.go we need to do the cleanup

fedekunze picture fedekunze on 28 May 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

fedekunze picture fedekunze  路  3Comments
hendrikhofstadt picture hendrikhofstadt  路  3Comments
johnmcdowall picture johnmcdowall  路  3Comments
ValarDragon picture ValarDragon  路  3Comments
mossid picture mossid  路  3Comments