Cosmos-sdk: Game of Stakes / gaia-9002 release checklist

Created on 9 Nov 2018  路  7Comments  路  Source: cosmos/cosmos-sdk

Tendermint Changes:

The following PRs are absolutely, unequivocally, indisputably required:

The following PRs may need to be merged for Game of Stakes:

  • [x] https://github.com/cosmos/cosmos-sdk/issues/2872 - Debug leftover distribution coins on export
  • [x] [#2839](https://github.com/cosmos/cosmos-sdk/pull/2839) - Gas uint64 (R4R)
  • [x] https://github.com/cosmos/cosmos-sdk/pull/2807 - Runtime-assertable invariants (@cwgoes )
  • [x] [#2801](https://github.com/cosmos/cosmos-sdk/pull/2801) - Remove AppInit (ready for review)
  • [x] [#2752](https://github.com/cosmos/cosmos-sdk/pull/2752) - Hard coded bonded denom
  • [x] [#2746](https://github.com/cosmos/cosmos-sdk/pull/2746) - Use correct prefix for show-address
  • [x] [#2728](https://github.com/cosmos/cosmos-sdk/pull/2728) - Reorg CLI command structure (docs updated)
  • [x] [#2727](https://github.com/cosmos/cosmos-sdk/pull/2727) - Fix unbonding command flow
  • [x] [#2709](https://github.com/cosmos/cosmos-sdk/pull/2709) - Makefile OS compatibility fix
  • [x] [#2682](https://github.com/cosmos/cosmos-sdk/pull/2682) - Simulator commission rate fix
  • [x] [#2565](https://github.com/cosmos/cosmos-sdk/pull/2565) - Validator delegations querier
  • [x] [#2808](https://github.com/cosmos/cosmos-sdk/pull/2808) - Docs Refactor (R4R)

The following issues really should be investigated prior to Game of Stakes:

Most helpful comment

@jackzampolin @gamarin2 do we want gas uint (#2839) in for GoS? I believe it's ready.

All 7 comments

@jackzampolin Can we add #2576 as well (it's R4R)? otherwise we'll have to use hardcoded values for the gov params on Voyager

stake bond denom refactor cannot be merged for 9001. Also that PR isn't complete, so, will do for GoS instead.

gaia-9001 is down due to Consensus Failure.

link to bugs:
https://github.com/cosmos/cosmos-sdk/issues/2772
https://github.com/cosmos/cosmos-sdk/issues/2776 (Attacker can submit TX with negative Fee minting tokens 馃憦)

Would be great to fix excessive logging of "Send failed" as well: https://github.com/tendermint/tendermint/issues/1817

I'd recommend logging as "debug" level or not at all. Logging "Send failed" with error severity seems wrong, provides little operational information and makes logs fill up quickly.

@mdyring yes, we've discussed this along with a few other logging tweaks. I wouldn't say it's critical to get in, but certainly if we can!

@jackzampolin @gamarin2 do we want gas uint (#2839) in for GoS? I believe it's ready.

v0.27.0 just got cut. Closing this issue.

Was this page helpful?
0 / 5 - 0 ratings