Cosmos-sdk: ci/circleci: go version differs from what is in .circleci/config.yml

[HaoyangLiu]

I created a PR and it invoked a circleci test. But the cicleci test failed

If the golang version is later than 1.10, my PR won't encounter circleci test failure. But the golang version of cicleci test docker image is 1.9.1. My point is why we still use golang 1.9.1 to run circleci test. Can someone help to clarify this issue?

[alexanderbez]

We should probably update this to 1.11.

[ValarDragon]

I don't think we should update CI to 1.11. We currently state that we support 1.10+, so CI should be running on 1.10. CI is currently on 1.10.3

[ValarDragon]

Oh huh, even though .circleci states its on 1.10.3, in your PR its running 1.9. I'm not sure whats going on.

[HaoyangLiu]

The docker image name of CI is circleci/golang:1.10.3. But actually, the golang version is 1.9.1

[HaoyangLiu]

Maybe there is something wrong in the docker image

[alexanderbez]

We currently state that we support 1.10+

@ValarDragon but we don't atm. Try building develop. Ref: #2253

We should fix whatever dependencies we need to to continue to support 1.10 or state otherwise.

[ValarDragon]

It works for me on 1.10.1. If we come to consensus on just dropping on 1.10 support, thats fine. (I'll just go ahead and upgrade :() Until then though, I think CI should remain 1.10. (I'm in favor of supporting 1.10 until we want some 1.11 feature)

[alexanderbez]

Mhmmm, you tried building cleanly off of the latest develop? Strange....

[ValarDragon]

Yup, make get_vendor_deps, make install succeeds for me on develop.

[alexanderbez]

haha, ok, I take back my statement then 👍

[cwgoes]

Fixed.