Cosmos-sdk: SDK 0.25 / Gaia-9000 release checklist

Created on 3 Sep 2018  Â·  23Comments  Â·  Source: cosmos/cosmos-sdk

Blocks:

  • [x] Simulation fixes for distribution module (@cwgoes / @rigelrozanski) #2501

Good to get in:

  • [ ] Vesting accounts (@alexanderbez) #2694 (currently blocked on final implementation detail)

Necessary for GoS but not gaia-9000:

  • [ ] Import/export fix (@cwgoes) #2690

Completed:

  • [x] Inflation distribution & commission (@rigelrozanski) #2527
  • [x] GenTx -> StdTx refactor (@alessio) #2422
  • [x] Removed validators are still slashable (@cwgoes / @sunnya97) #1673
  • [x] Faulty slashing when ex-validator is reintroduced into the validator set (@cwgoes) #1867
  • [x] Piggy bank implementation (@rigelrozanski) #2236
  • [x] Validator slashing logic (@cwgoes ) #2372
  • [x] Validator power rankings (@ValarDragon) #2439
  • [x] Add redelegation index (@cwgoes / @ValarDragon) #1402
  • [x] Validator Queues (@sunnya97) #2412
  • [x] Redegation/Unbonding (@sunnya97) #2393
  • [x] Validator unbonding state (#2163)
  • [x] Slashing period spec & implementation (#2001 , #2122)
  • [x] Piggy bank fee distribution spec (#1944)
  • [x] Transaction simulation, split generate/sign/broadcast (#2204)
  • [x] Fix staking bugs (#2189, #2277)
  • [x] Simple flat fee set in config.toml (#1861)
  • [x] Update to Tendermint 0.24 (#2219)
  • [x] Debug simulation invariant failure (#2162)
  • [x] Slashing changes for NextValSet (#2255)
  • [x] Debug faults caught in simulation (#2224, #2225)

Most helpful comment

Can we update the iavl version for next release? #2281

Let's do. Reviewed & merged.

All 23 comments

I thought tx simulation was done for now. (Were unsure if it's necessary as we haven't made a decision for how accurately were doing gas at launch)

One question from me: should the simulation be turned on by default?

On Mon, Sep 3, 2018 at 7:10 PM, Dev Ojha notifications@github.com wrote:

I thought tx simulation was done for now. (Were unsure if it's necessary
as we haven't made a decision for how accurately were doing gas at launch)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cosmos/cosmos-sdk/issues/2220#issuecomment-418163511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN_7AxIruu8iAPK4pL27GG-EmzFrMIdks5uXWJpgaJpZM4WXxi8
.

--
Alessio Treglia | [email protected]
0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A

I'd opt to leave it off for default until we make it not depend on privkey. If we enable it, we'll have to explain the UI to everyone using ledgers. (Plus my fears of side channel leakage only get exacerbated, especially since our underlying secp library isn't constant time)

Also weren't we aiming for SDK v0.25 by end of this week? If so, this feels a bit optimistic to me. (Like the ABCI codespace thing probably won't happen by end of this week, I'm unsure of the status of most of the purely SDK features)

Also weren't we aiming for SDK v0.25 by end of this week? If so, this feels a bit optimistic to me. (Like the ABCI codespace thing probably won't happen by end of this week, I'm unsure of the status of most of the purely SDK features)

Possibly, maybe we should target Monday/Tuesday. When do you expect the ABCI codespace & event updates to be merged upstream?

I think we are targeting monday/tuesday fwiw

I think we are targeting monday/tuesday fwiw

Also, I think we'll cut the ABCI updates from this release target since they aren't in TM 0.24.

Looking more like an end of week (thursday/friday) release after Standup today.

Can we update the iavl version for next release? #2281

Can we update the iavl version for next release? #2281

Let's do. Reviewed & merged.

Also we need to include https://github.com/cosmos/cosmos-sdk/pull/2210 in this release.

and #2326?

Awesome -- thanks for compiling that @cwgoes. It'll probably be best if we readdress those once the refactor (#2394) has been merged.

Updated the issue to reflect what needs doing.

I think I can also get to https://github.com/cosmos/cosmos-sdk/issues/1867 before GoS, since the other staking/slashing issues are done now.

Added to the list above.

I think https://github.com/cosmos/cosmos-sdk/issues/1673 has to block GoS, it's too much of an attack vector.

Closing this issue as we have cut the 0.25 release

Was this page helpful?
0 / 5 - 0 ratings