Cosmos-sdk: Cannot edit validator information

[kwunyeung]

Summary of Bug

I cannot update my validator information. No matter how I put the --moniker, --website, --details and --keybase-sig flags in different orders or values, only --moniker is updated.

Steps to Reproduce

I ran the following command

gaiacli stake edit-validator --address-validator=cosmosaccaddr10505nl7yftsme9jk2glhjhta7w0475uva87paj --chain-id=gaia-7001 --details="Recommend. Refer. Reward" --from=forbole --keybase-sig=4A5D9C100A76D9A8 --moniker=Forbole --website="https://www.forbole.com" --gas=100000000

And the validator information became this.
https://explorecosmos.network/validators/cosmosaccaddr10505nl7yftsme9jk2glhjhta7w0475uva87paj

all fields are showing [do-not-modify] which is the default value like I didn't input anything for the flags.

The last time I tried was at this block.
Committed at block 9526. Hash: 2D3FE934071D320092672431597F15EB8E557CAF

but the bond height of the validator didn't change.

---

For Admin Use

• [ ] Not duplicate issue
• [ ] Appropriate labels applied
• [ ] Appropriate contributors tagged
• [ ] Contributor assigned/self-assigned

[ValarDragon]

Theres a bug in the source that @sunnya97 and @jinghiskwon found.

Basically for some reason, if you don't set a validator config parameter, it defaults to [do-not-modify]. The [do-not-modify] is special, in that it can't be altered despite txs sent to it.

I believe the correct solution here is to just make the default behaviour to not default to [do-not-modify]. I think @sunnya97 was writing a PR for this?

[rigelrozanski]

So weird - I bet this is happening because the flag definition is common between create-validator and edit-validator. yeah for a new validator the desired behaviour is to set the metadata as the empty string unless something is provided NOT to set it to [do-not-modify] should be a quick fix.... @ValarDragon want to take this on?

[ValarDragon]

Talked to sunny, he said he'd take care of this.

[kwunyeung]

@sunnya97 @rigelrozanski the [do-not-modify] bug is still there in gaia-7003.

I first edited validator

gaiacli stake edit-validator --address-validator=cosmosaccaddr10505nl7yftsme9jk2glhjhta7w0475uva87paj --async=true --chain-id=gaia-7003 --from=Forbole --gas=1000000000 --keybase-sig=4A5D9C100A76D9A8 --moniker=Forbole --details="Recommend. Refer. Reward." --website="https://www.forbole.com"

Async tx sent. tx hash: 6E9C829B9FFBAC282DD5C5D010ACD50B278561CD

The validator information updated.

Then I edited the validator again without --details and --website

gaiacli stake edit-validator --address-validator=cosmosaccaddr10505nl7yftsme9jk2glhjhta7w0475uva87paj --async=true --chain-id=gaia-7003 --from=Forbole --gas=1000000000 --keybase-sig=4A5D9C100A76D9A8 --moniker=Forbole

Async tx sent. tx hash: 3D30936A3715B495FF8E50C484E799FD809710DD

Description of the validator became

Description: {Forbole 4A5D9C100A76D9A8 [do-not-modify] [do-not-modify]}

which is expected.

Then I edited the validator again.

gaiacli stake edit-validator --address-validator=cosmosaccaddr10505nl7yftsme9jk2glhjhta7w0475uva87paj --async=true --chain-id=gaia-7003 --from=Forbole --gas=1000000000 --keybase-sig=4A5D9C100A76D9A8 --moniker=Forbole --details="Recommend. Refer. Reward." --website="https://www.forbole.com"

Async tx sent. tx hash: 09295DB68942D0B319AE830C69BE068D3E1925D4

But the description is still

Description: {Forbole 4A5D9C100A76D9A8 [do-not-modify] [do-not-modify]}

[ValarDragon]

Thats expected, this commit isn't in the tagged release. This was mostly a release to fix the consensus critical bugs.