Cosmos-sdk: Add Gopkg.lock in gitignore?
It does not affect the code but generated each time running make ci.
CI
mossid
>All comments
Run make update_tools, dep updated which may be whats causing it to change.
I think we want Gopkg.lock in the source tree, since that ensures we're all running the same version of dependencies.
The differences are being caused by the inclusion of pruneopts and digest in the lock file, which dep says is now required. https://golang.github.io/dep/docs/Gopkg.lock.html
EDIT: Also thought of another reason to keep this. For people installing the SDK for testnets, they don't have to go through the much longer initial build process where dep tries to figure out whats the right version.
ValarDragon
on 17 Jul 2018
👍3
Was this page helpful?
0 / 5 - 0 ratings
Related issues
ValarDragon
路
3Comments
rigelrozanski
路
3Comments
rigelrozanski
路
3Comments
cwgoes
路
3Comments
fedekunze
路
3Comments
Most helpful comment
Run
make update_tools, dep updated which may be whats causing it to change.I think we want Gopkg.lock in the source tree, since that ensures we're all running the same version of dependencies.
The differences are being caused by the inclusion of pruneopts and digest in the lock file, which dep says is now required. https://golang.github.io/dep/docs/Gopkg.lock.html
EDIT: Also thought of another reason to keep this. For people installing the SDK for testnets, they don't have to go through the much longer initial build process where dep tries to figure out whats the right version.