Cosmos-sdk: crypto/keys: Rewrite API for exporting data

Created on 12 Jul 2018 · 6Comments · Source: cosmos/cosmos-sdk

Currently the API is incredibly confusing. Once understood, it is entirely unhelpful to anyone trying to get the raw value for their private key. (E.g. automated things, like our faucet)

Export is exporting the info, but armoring it. The armor method, and the actual info types are not exported, so they have no way of decoding the armor, or parsing the info values. It doesn't help that the Export methods don't have associated godocs. We should probably just recreate the import/export interface. I ran into these issues when trying to make a script to extract the privkey for usage in some automation stuff.

Legacy API keys

Source

ValarDragon

All 6 comments

Another point, client/GetKeyBase doesnt' take home directory as an arg, uses viper. This means it can only be used from within the CLI. This is a candidate for being in an internal package, as I didn't check the actual code in it, as the godoc didn't provide me a warning. This shouldn't be something that we export.

ValarDragon on 13 Jul 2018

👍1

Yeah viper removal is key

rigelrozanski on 13 Jul 2018

👍1

Happy to take this on me

alessio on 19 Sep 2018

BTW this sounds quite related to #2020

alessio on 19 Sep 2018

That'd be great! The prelaunch tags were added before our realization that we can put more and more to postlaunch though. As this is mostly API reworking, we can move it to pre1.0 as well.

ValarDragon on 19 Sep 2018

👍1

closing in favor of #2020