Coreruleset: Fix 920440 "URL file extension is restricted by policy" regex

Created on 13 May 2020  路  5Comments  路  Source: coreruleset/coreruleset

_Issue for tracking original pull request created by user theMiddleBlue on date 2019-01-28 09:58:27.
Link to original PR: https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/1297._

HEAD is: 03b0b408b5032f7fda3697475cf408df2f32bf70
BASE is: 4ad894096c4100a8a3813b24cd47d51ac8d50cbd
Referring to #1296 this fix the 920440 regex to \.[^\.]+$ preventing to make it match something like .com.sql instead of .sql.

All 5 comments

_User fgsch commented on date 2019-01-28 11:04:52:_

You don't need to escape the period inside a character class. Otherwise LGTM.

_User theMiddleBlue commented on date 2019-01-28 11:06:20:_

thanks fgsch I try to commit it without escape

_User fgsch commented on date 2019-01-28 12:56:06:_

You probably want to rebase it to exclude all the other changes/commits too.

_User theMiddleBlue commented on date 2019-01-28 16:17:20:_

fgsch I think I've done with rebase. Could you check if it's ok?

_User fgsch commented on date 2019-01-28 17:05:35:_

Perfect!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

CRS-migration-bot picture CRS-migration-bot  路  8Comments

CRS-migration-bot picture CRS-migration-bot  路  15Comments

CRS-migration-bot picture CRS-migration-bot  路  10Comments

CRS-migration-bot picture CRS-migration-bot  路  11Comments

CRS-migration-bot picture CRS-migration-bot  路  7Comments