Corefxlab: [Question] Separate Enums and Class to Different Files

Created on 7 Jul 2018  路  3Comments  路  Source: dotnet/corefxlab

Would it be appropriate to separate enums and class to their own code files or is the standard for this repo okay with grouping? I can create a PR if it is better to separate. Let me know.

For example, Pin.cs includes PinMode, PinValue, Pin, etc.

question or comment

All 3 comments

Generally speaking, we try to separate enums and classes into their own files. However, we don't follow that guidelines too strictly. PRs are definitely welcome :)

cc @edgardozoppi

I was planning to do it later since I wanted to concentrate in more important things first. :)
@shaggygi I appreciate your comment but I think there is no need for you to spend time in creating a PR for this, I will take care of it soon. The reason is I am still making lots of changes to the project and moving code between files at this point will create several git conflicts that I would like to avoid if possible. Thanks!

This change is included in PR #2400.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ahsonkhan picture ahsonkhan  路  9Comments

Drawaes picture Drawaes  路  10Comments

omariom picture omariom  路  3Comments

TylerBrinkley picture TylerBrinkley  路  9Comments

GrabYourPitchforks picture GrabYourPitchforks  路  9Comments