Coredns: plugin/auto|file: fully deprecate TIMEOUT + NO_RELOAD
Current (PR #2516) workings:
TIMEOUT & RELOAD not set -> 60s for both
TIMEOUT set -> use value for both
RELOAD set -> use value for both
TIMEOUT & RELOAD set -> use specific values
Deprecated implementation TIMEOUT:
TIMEOUT set -> error
RELOAD not set -> 60s default
RELOAD set -> use specific value
Deprectated implementation NO_RELOAD:
NO_RELOAD set -> error
Release notes:
Breaking: plugin/auto removes TIMEOUT and NO_RELOAD. plugin/file removes NO_RELOAD. Both plugin/file and plugin/auto now only allows the usage of RELOAD.
stp-ip
All 4 comments
@nzoueifi as you worked on the previous PR. Do you want to take this up?
That would mean the final deprecation would be done in 1.6.0
stp-ip
on 31 Mar 2019
Or @ihac :)
stp-ip
on 31 Mar 2019
@stp-ip Thanks for reminding. I'll create a pr today.
ihac
on 31 Mar 2019
We can just include it in 150, I can wait a bit
On Sun, 31 Mar 2019, 11:32 Xiao An, notifications@github.com wrote:
@stp-ip https://github.com/stp-ip Thanks for reminding. I'll create a
pr today.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/coredns/coredns/issues/2537#issuecomment-478329755,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVkWy8Sf9Ieyt-GitcscfCmAjXyh6BTks5vcI6_gaJpZM4avfMy
.
miekg
on 31 Mar 2019
Related issues
Mynom
·
5Comments
miekg
·
5Comments
ghost
·
6Comments
miekg
·
6Comments
haozi4263
·
5Comments
Most helpful comment
We can just include it in 150, I can wait a bit
On Sun, 31 Mar 2019, 11:32 Xiao An, notifications@github.com wrote: