Core: Rewrite google_wifi unittest tests to pytest style test functions

Created on 1 Oct 2020  路  4Comments  路  Source: home-assistant/core

Problem

The google_wifi integration still contains unittest.TestCase based unit tests. We want to rewrite them to standalone pytest test functions.

Background

The Home Assistant core standard is to write tests as standalone pytest test functions. We still have some old tests that are based on unittest.TestCase. We want all these tests to be rewritten as pytest test functions.

Here are the docs for pytest: https://docs.pytest.org/en/stable/

Here's an example of an async pytest test function in Home Assistant core:

https://github.com/home-assistant/core/blob/4cce724473233d4fb32c08bd251940b1ce2ba570/tests/components/tradfri/test_light.py#L156-L176

There are many pytest fixtures to help writing the tests. See:

Here's an example of a pull request that rewrote a module of unittest.TestCase tests to standalone pytest test functions:
https://github.com/home-assistant/core/pull/40749

Here's an example command to run a single test module with pytest inside tox on Python 3.8:

tox -e py38 -- --cov-report term-missing --cov=homeassistant.components.command_line.switch tests/components/command_line/test_switch.py

It will print coverage information with lines that are missing coverage.

Prerequisites

Task

  • Rewrite the tests one module at a time and submit the changes as a pull request to this repository.
  • We want to limit the change scope to a single module to not have the pull request be too long, which would take longer time to review.
  • Remember to reference this issue in your pull request, but don't close or fix the issue until all tests for the integration are updated.
Hacktoberfest Help wanted google_wifi unittest.TestCase

All 4 comments

Hi, can I work on this issue please?

Yes, please go ahead. 馃憤

Would you assign me this?

Done.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

neonandu picture neonandu  路  3Comments

TheZoker picture TheZoker  路  3Comments

missedtheapex picture missedtheapex  路  3Comments

Konstigt picture Konstigt  路  3Comments

piitaya picture piitaya  路  3Comments