Core: Breaking change in 2.5.5

Created on 22 Apr 2020  路  5Comments  路  Source: api-platform/core

API Platform version(s) affected: 2.5.5

Description
A new argument was added to ApiPlatform\Core\Bridge\Doctrine\Orm\Filter\SearchFilter::addWhereByStrategy which is not introduced to changelog.

Does the api platform follows semantic versioning? Because patch and minor releases should not contain breaking changes

bug

Most helpful comment

@rmikalkenas we do follow semver, but bugs happen ;) We're on it!

All 5 comments

Oh indeed, this is my fault, I thought we added this argument as last with a default value to minimize the impact... I wish we had an interface so that I'd have seed this earlier.

Impact from https://github.com/api-platform/core/pull/3331/files

@rmikalkenas we do follow semver, but bugs happen ;) We're on it!

Hi,

I understand that the parameter is placed wrong and delivers a beautiful BC.
But also this revert breaks my entire app filtering by subresource binary uuid.
There is any chance to have this implemented back any time soon?

Thanks,

Paul

this has been reverted in 2.5.6

;(
a BC with a BC.
For whom will need you can bring back the functionality by using the 2.5.5 SearchFilter in your src and use that instead the 2.5.6 one.

Was this page helpful?
0 / 5 - 0 ratings