Core: Add missing parameter $defaultContext for Swagger docs normalizer

Created on 9 Mar 2020  路  5Comments  路  Source: api-platform/core

API Platform version(s) affected: 2.5

Description
The service definition for api_platform.swagger.normalizer.documentation was missing a value for the $defaultContext parameter. Since the $defaultContext and $swaggerVersions are both arrays the issue did not appear to be easily visible.

How to reproduce
Build the container and take a look at the definition for api_platform.swagger.normalizer.documentation

Possible Solution
I've created a PR to fix this for branch 2.5

bug duplicate
Source
picture rendler-denis
👍1

Most helpful comment

thnaks @rendler-denis

picture soyuka on 13 Mar 2020
🚀1 🎉1 👍1

All 5 comments

Why do I have a feeling of deja vu ? https://github.com/api-platform/core/pull/3338

soyuka picture soyuka on 12 Mar 2020

:laughing: at least my fix doesn't break any tests. I did look for a similar issue, but since I am already pressured by time and I had a quick fix I thought let's do this. you can close it if you consider not needing it.

rendler-denis picture rendler-denis on 12 Mar 2020
👍1

thnaks @rendler-denis

soyuka picture soyuka on 13 Mar 2020
🚀1 🎉1 👍1

Hmm... We need to improve our behavioural tests then. Something like this should have been caught...

teohhanhui picture teohhanhui on 13 Mar 2020

This class suffers from too many arguments anyway. :laughing: :sweat:

teohhanhui picture teohhanhui on 13 Mar 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

DenisVorobyov picture DenisVorobyov  路  3Comments
Tjeerd picture Tjeerd  路  3Comments
dematerializer picture dematerializer  路  3Comments
tezvi picture tezvi  路  3Comments
lukasluecke picture lukasluecke  路  3Comments