Core: There's pushover notification devices regression after upgrade from 0.105.5 to 0.106.0

[meandes]

The problem

Pushover notifications to specific devices does not work after upgrade from 105.5 to 106.0.
Notification is sent to all the devices of pushover account regardless a list of devices provided.
After rollback to 105.5 notification works as expected.

See the example of notifcation data:

data:
device: oneplusa6010
priority: '1'
sound: pushover
message: Test notifcation to oneplusa6010
title: Test notification

In data device "oneplusa6010" is stated and before 106.0 upgrade notification was sent specifically to this device. After upgrade notification is sent to all the devices of pushover account.
Looks like device gets corrupted when sent to pushover server API and in case of unknown device pushover sends a notification to all the devices of the account.

Environment

• Home Assistant release with the issue:
  0.106.0
• Last working Home Assistant release (if known):
  0.105.5 . Rollback to this version resolved the issue
• Operating environment (Hass.io/Docker/Windows/etc.):
  Rasspbian PI3
• Integration causing this issue:
  Pushover
• Link to integration documentation on our website:

Problem-relevant configuration.yaml

Example is provided about that can be used with notify.pushover service

Traceback/Error logs

No log or errors are in the log.
If there's a way to activate some debug for pushover integration part please let me know

Additional information

[SchmDan]

I don‘t think this issue is solved, since attribute „device“ still can‘t be used...

[axilleas]

@balloob my mistake, this issue shouldn't have been closed with https://github.com/home-assistant/core/pull/32440!

I reproduced the bug.

[TEDSv]

Same problem =/
106 broke my smart home at all. first cant open supervisor page, after supervisor doesn`t start, and now pushover.
Some news for that issue?

[androidemil]

Still not working in 0.107.7

Does anyone know a good workaround for this until this is fixed?

[martinhoess]

Still not working in 0.107.7

Does anyone know a good workaround for this until this is fixed?

https://github.com/home-assistant/core/issues/32236#issuecomment-594457038

[androidemil]

Thanks martinhoess, I think it was broken with https://github.com/home-assistant/core/pull/31647

With this change all attributes possible to use has to be listed in notify.py and the device attribute is sill not listed resulting in it not being possible to use.

I don't have the environment setup to do a pull-request with tests and so, but the change should be fairly simple.

In notify.py
(https://github.com/home-assistant/core/blob/dev/homeassistant/components/pushover/notify.py)

Row 25 add line:
ATTR_DEVICE = "device"

row 68 add line:
device= data.get(ATTR_DEVICE, None)

row 110 add:
device,

[martinhoess]

@androidemil I think I'm using the version/state from 2020/01/11 .

I also don't have any dev/test setup for HA and I'll use the old state as long as the integration is broken (for my use cases) #32236 (second bullet point)

[androidemil]

Found the solution to it!
It was a breaking change in #31647 and the configuration page was not updated.

The devices should now be defined as target on the same level as title and message. It should no longer be as device in the data field.
If a incorrect or disabled pushover device is entered, it will send to all

Use

 service-data:
    message: "This is the message"
    title: "Title of message"
    target:
    - devicename1
    - devicename2
    data:
      sound: pianobar
      priority: 0

instead of previous

 service-data:
    message: "This is the message"
    title: "Title of message"
    data:
      device: devicename1
      sound: pianobar
      priority: 0

I have submitted a pull request to update the documentation for it

[TEDSv]

Found the solution to it!
It was a breaking change in #31647 and the configuration page was not updated.

The devices should now be defined as target on the same level as title and message. It should no longer be as device in the data field.
If a incorrect or disabled pushover device is entered, it will send to all

Use

 service-data:
    message: "This is the message"
    title: "Title of message"
    target:
    - devicename1
    - devicename2
    data:
      sound: pianobar
      priority: 0

instead of previous

 service-data:
    message: "This is the message"
    title: "Title of message"
    data:
      device: devicename1
      sound: pianobar
      priority: 0

I have submitted a pull request to update the documentation for it

Thanks man!

[Geronimo2015]

Is fixing URL support for attachment planned?

[martinhoess]

Is fixing URL support for attachment planned?

If you read @balloob comments here I don't think so ...

[Geronimo2015]

Is fixing URL support for attachment planned?

If you read @balloob comments here I don't think so ...

I worked around it by making a camera snaphot and pushing local jpeg file.

[stale[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.