Core: Konnected Config Flow issues in 106 beta

Created on 22 Feb 2020  路  12Comments  路  Source: home-assistant/core

The problem

The config flow update for the Konnected component in https://github.com/home-assistant/home-assistant/pull/30894 is non-breaking in theory, but in reality can cause some confusion/frustration for users.
1) The integration is discovered twice if it is already configured via YAML, but the config flow for both is the same. When clicking "Configure" the yaml version doesn't populate the host/port because it was previously handled by discovery and wasn't necessary to include in the config yaml. The new SSDP discovery implementation does indeed pre-populate the host and port, so that is what I chose to setup.
2) The documentation says yaml configurations are brought in automatically, but that does not appear to be working correctly. Konnected must be setup on the Integrations page first. Also, the old entities are appearing as unavailable via the "Entities" tab until the "Zone" is enabled in the integration and configured via the config entry options. This could be due to the fact that I chose the "wrong" discovered Konnected.io integration and the auto-import to config flow did not work.
3) Lastly, the options flow is not really self documenting. I was able to figure it out, but the new docs could really use some love with screenshots or more detailed instructions.

Environment

  • Home Assistant release with the issue: 0.106 beta
  • Last working Home Assistant release (if known): 0.105.5
  • Operating environment (Hass.io/Docker/Windows/etc.): All
  • Integration causing this issue: Konnected
  • Link to integration documentation on our website: https://rc.home-assistant.io/integrations/konnected/
konnected

Most helpful comment

@hunterjm I'll look into how to clean these up. Thanks for the great feedback.

All 12 comments

Pinging @kit-klein as the author of the PR if he wants to take a look.

Hey there @heythisisnate, @kit-klein, mind taking a look at this issue as its been labeled with a integration (konnected) you are listed as a codeowner for? Thanks!

@hunterjm I'll look into how to clean these up. Thanks for the great feedback.

No problem, let me know if you need any additional details. Unfortunately I didn't have the foresight to take screenshots or document anything in detail. I upgraded to the beta relatively late the other night and wanted to make sure all my door sensor automations would still work for us in the morning.

@hunterjm #32138 will help greatly with items 1 and 2. It removes the duplicates in the discovered integration list and utilizes the configuration.yaml entity setups as soon as the config entry is created. Options flow is now only required to modify or create settings that weren't in configuration.yaml.

It's against the rules to completely auto import the configuration.yaml into a config entry without some user confirmation but I believe the referenced PR above streamlines the process as much as possible.

For item 3 I agree. We'll get some doc updates in the place in the near future. In the interim, #32119 addressed an issue with description placeholder not rendering. Having it fixed will give more explicit info on what zone you are configuring and hopefully avoid some confusion.

It's only against the rules to auto set up a discovered entry. It's not against the rules to import configuration.yaml automatically.

It's only against the rules to auto set up a discovered entry. It's not against the rules to import configuration.yaml automatically.

That's great. I didn't realize it only applied to discovery. Then we can further improve the konnected config flow for import scenarios.

Removed the 0.106.0 milestone, while it is still an issue, it cannot be improved before this release anymore.

I don't know if this is part of the same problem that is being mentioned with Konnected but I have a zone that is controlling a piezo buzzer and I have that zone set up as 3 different switches each with different pauses and delays of beeps and the additional switches for that zone are now unavailable only the first switch for that zone works.

I propose we close this issue since report 1 and 2 should be fixed and 3 should be a docs issue.

I don't know if this is part of the same problem that is being mentioned with Konnected but I have a zone that is controlling a piezo buzzer and I have that zone set up as 3 different switches each with different pauses and delays of beeps and the additional switches for that zone are now unavailable only the first switch for that zone works.

@fourtrax01 This is definitely a different issue. Feel free to open up a new issue with details of what you're experiencing.

I agree with @MartinHjelmare. Closing this and will create a related docs issue for 3.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ofuangka picture ofuangka  路  3Comments

sibbl picture sibbl  路  3Comments

sogeniusio picture sogeniusio  路  3Comments

moskovskiy82 picture moskovskiy82  路  3Comments

Elmardus picture Elmardus  路  3Comments