Core: Installation of @ngx-translate/core also installs “semantic-release” (since version 12.1.0)

[voorproever]

Current behavior

The @ngx-translate/core package seems to depend on semantic-release since v12.1.0:

• https://www.npmjs.com/package/@ngx-translate/core/v/12.1.0?activeTab=dependencies
• https://www.npmjs.com/package/@ngx-translate/core/v/12.0.0?activeTab=dependencies

Expected behavior

No installation of semantic-release since it’s a devDependency.

Minimal reproduction of the problem with instructions

npm install @ngx-translate/core
less package-lock.json

[ocombe]

Thanks, good catch! It'll be fixed in the next version (I won't release a new version just for that)

[viceice]

Shouldn't it be a dependency on the root package.json?

[viceice]

Or install without adding to package.json at all?

btw: latest semantic-release is v17.0.3 and you are using v8.2.3

[ocombe]

As long as it works, I'm reluctant to change the setup since it does
releases automatically and it works fine 😁

[nicolashenry]

@ocombe Is it released? I still have it installed with @ngx-translate/core 12.1.1 :

[demisx]

Same issue here. The latest version still installs [email protected] and generates warnings in Angular 9 when the latter tries to compile all npm dependencies as esm2015. Please remove it from the dependencies, since it's not a requirement to run your app code.

https://www.npmjs.com/package/@ngx-translate/core/v/12.1.1?activeTab=dependencies

[ocombe]

Can you try 12.1.2 please? Hopefully it should be fixed for good now (based on https://www.npmjs.com/package/@ngx-translate/core/v/12.1.2?activeTab=dependencies)

[nicolashenry]

Seems fixed, thanks!

[demisx]

Yep, it's fixed. Thank you @ocombe 🙏