Core: Extraneous Vizio SmartCast discoveries

[michaelwoods]

The problem

The "Discovered" section is now showing many entries for configuring Vizio SmartCast devices. I only have 3 TVs and a speaker that would show up, however I see 14 entries.

Environment

• Home Assistant release with the issue: 0.105.1
• Last working Home Assistant release (if known): n/a
• Operating environment (Hass.io/Docker/Windows/etc.): docker
• Integration causing this issue: vizio
• Link to integration documentation on our website: https://www.home-assistant.io/integrations/vizio/

Problem-relevant configuration.yaml

n/a

Traceback/Error logs

2020-02-07 10:11:35 INFO (SyncWorker_8) [homeassistant.loader] Loaded vizio from homeassistant.components.vizio

Not really relevant.

Additional information

I use the devices with the media_player integration (via Google Cast) automatically. I don't really have any need for the direct Vizio integration. There's too many showing and there doesn't seem to be a way to ignore devices.

[probot-home-assistant[bot]]

Hey there @raman325, mind taking a look at this issue as its been labeled with a integration (vizio) you are listed as a codeowner for? Thanks!

[raman325]

I have a fix which will hopefully be included in 0.106 to address this. I will also look into adding support for the "Ignore" option for these

[raman325]

I added a fix for 105. This will not address the ignore issue, will have to look into that later

[roger-rainey]

the latest build still has this issue, did it get resolved?

[shinta86]

I am also having the same issue.

[raman325]

I have seen multiple reports of this but I can't figure out why the logic that exists isn't preventing this. I have tests to check for this that I just verified are still working, and I am not seeing this issue myself, so I am having a hard time finding the root cause of this. Reopening for now so I can keep tracking it

[sgruby]

My soundbar turns off everyday (outlet is turned off) and when it turns back in, I get the discovered box for it and then when I hit configure, I get a message that it aborted. My screenshots were on the forum. Let me know what info you want or what you'd like me to test. Thanks!

[raman325]

Thanks @sgruby I have a suspicion of what is happening which my PR ^ should address. Hopefully I will get some guidance on how to test for this so it doesn't happen again assuming that is indeed the solution.

[raman325]

please let me know if this is resolved once 0.117 is released

[BADGRRL666]

Same issue here with the "rapid" discovery.
Seems to only be the soundbar since this doesn't happen with the 2 other Vizio TV sets I have.
The model is SB3651 running on Home Assistant 0.116.4

Will write back if 0.117 fixes the issue, Thanks!

[shinta86]

Unfortunately, I am still having the problem with 0.117.

[raman325]

@shinta86 are they all ignorable? I may just have to remove zeroconf discovery for the integration until I can figure out what is going on. It's possible that Vizio changed their API which is preventing me from detecting the right thing.

What would really help is if someone could add the following to their config and then send me the zeroconf debug logs related to their vizio devices. You can send this to me privately if you'd prefer to avoid posting this information publicly, but it would be helpful to not mask the details that are discovered. Nothing there, like local IP, or serial number, should cause a security concern.

logger:
  default: warn
  logs:
    homeassistant.components.zeroconf: debug

[shinta86]

None of them are ignorable. I have the logs from the last 24 hours. How do I send them to you?

[raman325]

Are you on Discord? You can upload your log here: https://paste.ubuntu.com/ and send it to raman325#4076. Alternatively you can DM me (raman325) on the Community forums

[raman325]

Thanks @shinta86 found at least one issue I can fix, hopefully this will help make these go away

[raman325]

We will keep this open until someone confirms the issue is resolved

[mcarlson4]

@raman325 - Having this same issue, Still need someone to test with? Looks like you may have solved it and will be realized in .118? Let me know if you still need anything. Thank for your work on this!

[roger-rainey]

I implemented the change in my 0.117 build and I have not seen the vizio integration reappear. So I do expect the next release with this change will fix it.

[raman325]

Great to hear @roger-rainey I have no way to test this myself unfortunately

[BADGRRL666]

Just updated to 0.117.2 and the notifications disappeared.

Went ahead and re-added the soundbar that was giving me trouble and no new device discovery notifications even after 3 restarts.

Looks like it was fixed.

[raman325]

It seems that there are multiple issues. One of my PRs was released recently, the second one is still open but hopefully between the two we got em all

[roger-rainey]

I am still seeing discoveries pop up. I guess it just took a little more time than I expected

[raman325]

got it @roger-rainey well hopefully the latest PR addresses the problem

[raman325]

the changes related to this were pushed in 0.117.3. Please let me know if you continue to see the problem after updating

[sgruby]

I'm still seeing this in 0.117.4. Please let me what information you need. Thanks!

[raman325]

😞 Make the changes to your config as described here @sgruby : https://github.com/home-assistant/core/issues/31642#issuecomment-719883089

Once you have seen multiple entries for Vizio, send me the debug logs (you can find me on Discord or the community forums in case you don't want to share the unmasked data here)

[raman325]

I think this should be resolved in 0.118.0. Can anyone confirm?

[roger-rainey]

I have updated and I am not longer seeing this issue

[raman325]

Great! Closing this then, but will reopen if I see any additional feedback that suggests there is still a problem