Core: Page count incorrect when scrolling to bottom

[katosdev]

Bug Report

Current Behavior
When scrolling past the last post to the editor, the page count changes to an incorrect value. This has been reproduced across a range of devices and browsers by myself and @Ralkage

Steps to Reproduce

1. Go to any thread.
2. Browse to the last post and note the post count (eg 399/399)
3. Scroll down to the editor
4. See error - the post count will change (e.g. 349/399)

Video of bug
https://streamable.com/avmrw <--

[PeopleInside]

Confirmed.

[PeopleInside]

Hi, this seems to be now fixed in the Flarum community but I cannot see the fix here.
Hope to see how to fix this on my Flarum 10

[rob006]

This is not fixed on discuss. You can easily reproduce this by creating a long draft, so only your new post will be visible on screen - navigation will show you "1 of X posts" even if you're at the end of the discussion.

[katosdev]

In the interest of maintaining updates on this issue, please see below further discussion:
https://discuss.flarum.org/d/21747-page-count-incorrect-when-scrolling-to-bottom-1897

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[rob006]

bump

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[PeopleInside]

up :)

[katosdev]

@flarum/core Are we able to push this for B14? :)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[rob006]

bump

[askvortsov1]

This can be done by modifying the updateScrubber method of PostStreamState by returning count if we're past the end of the end of the stream; that is, no posts are in the viewport, and we are at the end (IE, PostStreamState.viewingEnd() is true)