Core: Files mediaviewer is not able to open files in oC 10.3.0 alpha2

[davitol]

Files mediaviewer is not able to reproduce videos or open photos when our ownCloud Server is configured with Files Primary S3 happens with regular storage. Files are downloaded but not reproduced. Tested with oC 10.3 and files_mediaviewer: 1.0.0 and files_primary_s3: 1.0.4 with Scality

[DeepDiver1975]

Anything in the Browser console?
Please compare response headers With and without s3. Thx

[davitol]

Title changed. It works fine in oC 10.2.1 but it is not able to reproduce files in oC 10.3.0 alpha2. Clicking on the media file, requests a download. (webdav)

Can it be maybe a problem loading js stuff?
Tested in Firefox and Chrome for Mac

[davitol]

Pair-tested with @individual-it in his enviroment. He can also reproduce it. So we have a regression in core and a blocker (Tested with owncloud-daily-master) @micbar JFYI too

[micbar]

@davitol @individual-it
I could not reproduce it

• OC 10.3.0alpha2
• Files Mediaviewer 1.0.0 (github checkout)
• Jpg and png files are working
• Firefox, Chrome, Safari on MAC

[davitol]

@mbarz please check with owncloud daily tarball (it is also labeled as alpha2) sorry for the misunderstanding
Please tell us if it is reproducible for you too with that version

[micbar]

@davitol
Checked OC 10.3.0alpha2 (Docker) with Mediaviewer 1.0.0 from Marketplace.

Works fine.

Now we need to look into the differences of our enviroments.

[VicDeo]

works for me in the following env:
OC master@e98fec80a6fcd08b77120ed6001e24bb707e5c24
files_mediaviewer master@e98fec80a6fcd08b77120ed6001e24bb707e5c24
files_primary_s3 master@31836f9d588f97cc5c61f5882d4c5f24719613e2

@davitol could you send me a link to the tarball that is failing for you?

[davitol]

@VicDeo Fails for me with this Tarball: https://download.owncloud.org/community/daily/owncloud-daily-master-qa.tar.bz2

[VicDeo]

@davitol @micbar unrelated to files_primary_s3, files_mediaviewer is not built properly:

deo@reborn:~/public_html/oc-103rc> ls -l apps/files_mediaviewer/
total 252
drwxr-xr-x 2 deo users   4096 Sep 22 23:02 appinfo
-rw-r--r-- 1 deo users    295 Sep 22 23:01 CHANGELOG.md
-rw-r--r-- 1 deo users  18092 Sep 22 23:01 LICENSE
-rw-r--r-- 1 deo users   1073 Sep 22 23:01 package.json
-rw-r--r-- 1 deo users   1081 Sep 22 23:01 README.md
drwxr-xr-x 4 deo users   4096 Sep 22 23:01 src
drwxr-xr-x 2 deo users   4096 Sep 22 23:01 templates
-rw-r--r-- 1 deo users    898 Sep 22 23:01 webpack.config.js
-rw-r--r-- 1 deo users 208696 Sep 22 23:01 yarn.lock

deo@reborn:~/public_html/oc-103rc> ls -l ../oc-master/apps/files_mediaviewer/
total 524
drwxr-xr-x   2 deo users   4096 Sep 20 15:40 appinfo
-rw-r--r--   1 deo users    295 Sep 20 15:40 CHANGELOG.md
drwxr-xr-x   2 deo users   4096 Sep 20 15:41 js
-rw-r--r--   1 deo users  18092 Sep 20 15:40 LICENSE
-rw-r--r--   1 deo users   1925 Sep 20 15:40 Makefile
drwxr-xr-x 490 deo users  20480 Sep 20 15:41 node_modules
-rw-r--r--   1 deo users   1073 Sep 20 15:40 package.json
-rw-r--r--   1 deo users 247575 Sep 20 15:41 package-lock.json
-rw-r--r--   1 deo users   1081 Sep 20 15:40 README.md
drwxr-xr-x   4 deo users   4096 Sep 20 15:40 src
drwxr-xr-x   2 deo users   4096 Sep 20 15:40 templates
-rw-r--r--   1 deo users    898 Sep 20 15:40 webpack.config.js
-rw-r--r--   1 deo users 208696 Sep 20 15:40 yarn.lock

it's obvious, release should have js directory instead of src

[VicDeo]

so. if I got meaning of build correct, it should be true here https://github.com/owncloud/administration-internal/blob/master/release-scripts/config/owncloud-daily-master-qa.json#L112

[VicDeo]

I checked the tarball built on 09/23/2019 09:00:06 PM and owncloud/apps/files_mediaviewer/js directory is still missing there

[VicDeo]

The PR above DO fix the ussue, probably it needs deploying to the release server.
Here is what I have when I run the script locally:

~> php release.php make config/owncloud-daily-master-qa.json
...
~> ls -l temp-releases/owncloud/apps/files_mediaviewer/
total 40
drwxr-xr-x 2 deo users  4096 Sep 24 11:48 appinfo
-rw-r--r-- 1 deo users   295 Sep 24 11:48 CHANGELOG.md
drwxr-xr-x 2 deo users  4096 Sep 24 11:48 js
-rw-r--r-- 1 deo users 18092 Sep 24 11:48 LICENSE
-rw-r--r-- 1 deo users  1081 Sep 24 11:48 README.md
drwxr-xr-x 2 deo users  4096 Sep 24 11:48 templates

[davitol]

I checked the tarball built on 09/23/2019 09:00:06 PM and owncloud/apps/files_mediaviewer/js directory is still missing there

I had checked also with today's daily tarball and yes, it is still missing

[davitol]

Who can take care of the deployment in the release server? @tboerger maybe?

[tboerger]

I'm not in charge of that.

[VicDeo]

@davitol the files_mediaviewer app is built in dailies now.
Could you please retest if the issue is not reproducible anymore?

[davitol]

Works fine in $OC_Build = '2019-09-25T20:00:31+00:00 31ea320a69be5fa9f4c92eb3f25ed816ba810a5d';Let's close the ticket @VicDeo