Core: Tesla Component stopped working in v0.96.x (and v0.97.0)

[rudgr]

Home Assistant release with the issue:

0.97.0

Last working Home Assistant release (if known):
0.95.x

Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io

Component/platform:

https://www.home-assistant.io/components/tesla/

Description of problem:

• Seems that since the 0.96.0 release the tesla component stopped working?
• Maybe related to the changes in the climate component?
• All tesla sensors (not only tesla climate sensor) show the "entity not available" message in lovelace UI
• 0.97.0 also produces same issues
• I don't see any tesla related issues in the home assistant log

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

# Tesla configuration.yaml entry
tesla:
  username: !secret tesla_username
  password: !secret tesla_password
  scan_interval: 3600

Traceback (if applicable):

I don't see any tesla related issues in the home assistant log

Additional information:
Issue confirmed by @G8YTZ in: #25247 https://github.com/home-assistant/home-assistant/issues/25247

[G8YTZ]

Same here, 0.96 and 0.97 all components "Entity not available" MY environment HASS.IO running in Docker on Ubuntu 18.04 on i3NUC

[G8YTZ]

Sorted it! The entity names have changed, basically remove the VIN number from the entity name. EXCEPT FOR THE LOCATION TRACKER. Problem is, what if you have more than one Tesla?

I wonder if this change has also affected Tile on another thread?

[rudgr]

ah great @G8YTZ , will give it a try! tx :)

[probot-home-assistant[bot]]

Hey there @zabuldon, mind taking a look at this issue as its been labeled with a integration (tesla) you are listed as a codeowner for? Thanks!

[rasssta]

I also find it a bit weird to remove the VIN number from entity names. For one, it broke all of my history in InfluxDB, and then also the obvious (as it seems?) issue when you have more than 1 Tesla.

[G8YTZ]

They did a similar thing with the condition monitoring of my Samsung Printer where the identity of each printer had the ip address as part of the entity, now they have done something else and I just get the toner levels reported as “unknown”

What’s really bugging me is that the have totally messed up the Lovelace thermostat card to the point it no longer works with KNX, being the largest building automation standard.

I love the Home Assistant project, but the constant breaking changes is getting tiresome. High time we have an LTS fork where releases keep entities the same and just features are added and right now the solution is totally unsupportable if you want to offer it as a customised solution.

[deftdawg]

I believe the problem is the removal of this line

        self.entity_id = ENTITY_ID_FORMAT.format(self.tesla_id)

by @pvizeli from all of the tesla component init methods.

Maybe there was a plan to replace that with unique_id implemented here? Not sure what the thoughts were for multiple vehicle households...

In any case the lines that were deleted

• https://github.com/home-assistant/home-assistant/commit/84cf76ba3688760fc311733a3f179865f1317c67#diff-323b0ced765982120ec5cdfbd509687cL28
• https://github.com/home-assistant/home-assistant/commit/84cf76ba3688760fc311733a3f179865f1317c67#diff-e9de1994d7221332057c4f9fee9bf61eL32
• https://github.com/home-assistant/home-assistant/commit/84cf76ba3688760fc311733a3f179865f1317c67#diff-2f398a4688e5e19eff97f12a8f6b8cb6L26
• https://github.com/home-assistant/home-assistant/commit/84cf76ba3688760fc311733a3f179865f1317c67#diff-88cfc4124fb379aa94dafc87a2c862f2L47
• https://github.com/home-assistant/home-assistant/commit/84cf76ba3688760fc311733a3f179865f1317c67#diff-f4f6a2af9b5d1ef1051a33d0a05379ddL31
• https://github.com/home-assistant/home-assistant/commit/84cf76ba3688760fc311733a3f179865f1317c67#diff-f4f6a2af9b5d1ef1051a33d0a05379ddL63

[trombonekenny]

Weeks later, nothing yet?

[deftdawg]

@trombonekenny, I attempted to revert @pvizeli 's changes around entity_id through a custom component override, however the entities didn't change their names back to include VIN, so HA may have been refactored to do entity naming a different way, I don't know and don't really have time to play with it... All my Tesla stuff is still broken, because I believe we need to get VIN back in there for multi-car households.

[G8YTZ]

For a one-Tesla household its not a massive issue, just I wish they would think things though things through before they make changes, a similar change was made to the Samsung Printers with the IP Address.

Definitely need a LTS version, as right now the solution is not supportable or usable as a service.I’m still gnashing my teeth over the KNX Thermostat Operations mode cock-up.

I’ll give HA some time as we are still on pre- v1.0 releases and the solution stands a real chance of becoming the best out there by far and I know a lot of people are spending a lot of time getting a superb solution out there. I am very happy to pay for Nabu Case that helps fund the ongoing development.

Justin
www.g8ytz.com http://www.g8ytz.com/
Sent from my Macbook

On 17 Sep 2019, at 15:06, Dave Mussulman [e-mail] wrote:

Weeks later, nothing yet?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/25809?email_source=notifications&email_token=AIR3TT5B6OZGWIRNVBPLY7DQKDP7BA5CNFSM4IKUGHC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD64URWI#issuecomment-532236505, or mute the thread https://github.com/notifications/unsubscribe-auth/AIR3TT5ZMWARBDF2RLXFB5DQKDP7BANCNFSM4IKUGHCQ.

[alandtse]

@pvizeli Can you please explain the reason for removing the ENTITY_ID_FORMAT? I'm about to work on this component again and would revert your change as it is a problem for multi-car households. The next version of the teslajsonpy will cut the amount of the VIN being shown if that was the concern.

EDIT: Forgot my manners. ;)