Core: EQ3 thermostats broken after update to 0.96

[shizlkazizl]

Home Assistant release with the issue:
0.96.0

Last working Home Assistant release (if known):
0.95.4

Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io

Component/platform:
EQ3 Bluetooth Smart Thermostats

Description of problem:

Error while setting up platform eq3btsmart
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 126, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT)
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 442, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/eq3btsmart/climate.py", line 69, in setup_platform
    devices.append(EQ3BTSmartThermostat(mac, name), True)
TypeError: append() takes exactly one argument (2 given)

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

climate:
  - platform: eq3btsmart
    devices:
      livingroom:
        mac: !secret 
      bedroom:
        mac: !secret
      kitchen:
        mac: !secret

[ghost]

Hey there @rytilahti, mind taking a look at this issue as its been labeled with a integration (eq3btsmart) you are listed as a codeowner for? Thanks!

_This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people._

[frenck]

Fixed in #25238 will land in 0.96.1.

[reaper7]

I updated HASS to 0.96.1 but eq3btsmart still does not work for me.
My config:

arch | armv7l
-- | --
dev | false
docker | false
hassio | false
os_name | Linux
python_version | 3.7.3
timezone | Europe/Warsaw
version | 0.96.1
virtualenv | true

climate.yaml:

- platform: eq3btsmart
  devices:
    salon_valve:
      mac: '00:1A:22:xx:xx:x1'
    small_room_valve:
      mac: '00:1A:22:xx:xx:x3'

Other ble devs like xiaomi temperature and humidity sensor works but eq3 not.

hcitool finds these devices:

sudo hcitool lescan
LE Scan ...
00:1A:22:xx:xx:x1 CC-RT-BLE
4C:65:A8:xx:xx:xx MJ_HT_V1
00:1A:22:xx:xx:x3 CC-RT-BLE

eq3cli too:

pi@rpi:~ $ eq3cli --mac 00:1A:22:xx:xx:x1
[00:1A:22:xx:xx:x1] Target 4.5 (mode: manual off dst, away: no)
Locked: False
Batter low: False
Window open: False
Window open temp: 12.0
Window open time: 0:15:00
Boost: False
Current target temp: 4.5
Current comfort temp: 21.0
Current eco temp: 17.0
Current temp offset: 0.5
Current mode: manual off dst
Valve: 0

pi@rpi:~ $ eq3cli --mac 00:1A:22:xx:xx:x3
[00:1A:22:xx:xx:x3] Target 4.5 (mode: manual off dst low battery, away: no)
Locked: False
Batter low: True
Window open: False
Window open temp: 12.0
Window open time: 0:15:00
Boost: False
Current target temp: 4.5
Current comfort temp: 21.0
Current eco temp: 17.0
Current temp offset: 1.0
Current mode: manual off dst low battery
Valve: 0

from HASS virtualenv bluepy/btle.py also foud my eq3 devices:

(homeassistant) pi@rpi:~/homeassistant/lib/python3.7/site-packages/bluepy $ python3 btle.py 00:1A:22:xx:xx:x1
Connecting to: 00:1A:22:xx:xx:x1, address type: public
Service <uuid=Generic Access handleStart=256 handleEnd=337> :
    Characteristic <Device Name>, hnd=0x110, supports READ
    -> b'CC-RT-BLE'
    Characteristic <Appearance>, hnd=0x120, supports READ
    -> b'\x00\x00'
    Characteristic <Peripheral Privacy Flag>, hnd=0x130, supports READ
    -> b'\x00'
    Characteristic <Reconnection Address>, hnd=0x140, supports WRITE
    Characteristic <Peripheral Preferred Connection Parameters>, hnd=0x150, supports READ
    -> b'\x00\x00\x00\x00\x00\x00\x00\x00'
Service <uuid=Generic Attribute handleStart=512 handleEnd=544> :
    Characteristic <Service Changed>, hnd=0x210, supports READ INDICATE
    -> b'\x00\x00\x00\x00'
Service <uuid=Device Information handleStart=768 handleEnd=801> :
    Characteristic <Manufacturer Name String>, hnd=0x310, supports READ
    -> b'eq-3'
    Characteristic <Model Number String>, hnd=0x320, supports READ
    -> b'CC-RT-BLE'
Service <uuid=3e135142-654f-9090-134a-a6ff5bb77046 handleStart=1024 handleEnd=1072> :
    Characteristic <3fa4585a-ce4a-3bad-db4b-b8df8179ea09>, hnd=0x410, supports READ WRITE
    -> b'\x03\x13\x07\x13\x11\x14:\x00\x00\x00\x00\x00\x00\x00\x00\x00'
    Characteristic <d0e8434d-cd29-0996-af41-6c90f4e0eb2a>, hnd=0x420, supports READ WRITE NOTIFY
    -> b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'
Service <uuid=9e5d1e47-5c13-43a0-8635-82ad38a1386f handleStart=65280 handleEnd=65287> :
    Characteristic <e3dd50bf-f7a7-4e99-838e-570a086c666b>, hnd=0xff01, supports WRITE NOTIFY INDICATE
    Characteristic <92e86c7a-d961-4091-b74f-2409e72efe36>, hnd=0xff04, supports WRITE
    Characteristic <347f7608-2e2d-47eb-913b-75d4edc4de3b>, hnd=0xff06, supports READ
    -> b'\x00\x10\x03\x02'

but HASS still show that devices are unavailable.

HASS log:

2019-07-19 16:58:25 INFO (MainThread) [homeassistant.components.climate] Setting up climate.eq3btsmart
2019-07-19 16:58:33 WARNING (SyncWorker_3) [homeassistant.components.eq3btsmart.climate] Updating the state failed: Device disconnected
2019-07-19 16:58:35 WARNING (MainThread) [homeassistant.components.climate] Setup of platform eq3btsmart is taking over 10 seconds.
2019-07-19 17:02:51 WARNING (SyncWorker_18) [homeassistant.components.eq3btsmart.climate] Updating the state failed: Failed to connect to peripheral 00:1A:22:xx:xx:x3, addr type: public
2019-07-19 17:03:49 WARNING (SyncWorker_6) [homeassistant.components.eq3btsmart.climate] Updating the state failed: Failed to connect to peripheral 00:1A:22:xx:xx:x3, addr type: public
2019-07-19 17:06:02 WARNING (SyncWorker_16) [homeassistant.components.eq3btsmart.climate] Updating the state failed: Failed to connect to peripheral 00:1A:22:xx:xx:x3, addr type: public
2019-07-19 17:07:58 WARNING (SyncWorker_14) [homeassistant.components.eq3btsmart.climate] Updating the state failed: Failed to connect to peripheral 00:1A:22:xx:xx:x3, addr type: public

Last 4 log entries inform about the device that is a long distance away, it has always been like that,
but there is no information about the error of reading the first device with mac 00:1A:22:xx:xx:x1,
so I conclude that it is read but because of some reason it is not shown

[dolenec]

I have completly the same error - something is broken regarding eq3 bluetooth termostat...

I tried restart several times, also restart HassOS, but nothing helps...

Is there any solution to that? I'm using 0.96.3..