Core: Adblock admin sharing settings hiding

Created on 19 Apr 2019 · 5Comments · Source: owncloud/core

Steps to reproduce

Enabled Adblock
Check admin settings
Disabled Adblock
Check again addmin settings

Expected behaviour

Warning on Adblock shown or sharing icon shown.

Maybe use idea by https://github.com/sualko/cloud_piwik/pull/65 or by https://github.com/nextcloud/server/pull/4337?

Actual behaviour

With Adblock no sharing icon

admin_adblock

Without Adblock sharing icon

admin_noadblock

Server configuration

ownCloud version: 10.1.1

Client configuration

Browser: Firefox 66.0.3 + Adblock +

Adblock Warning Removal List
Fanboy's Social Blocking List
ABP filters
EasyList
Allow nonintrusive advertising without third-party tracking

bug-analysis

Source

ho4ho

👍1

Most helpful comment

so it seems that renaming "share-" to "shared-" would solve the issue.

however if the icon file name needs to be renamed, it could have an impact on some themes that might use this name, so would consider this a breaking change that needs mentioning in release notes.

cc @pmaier1

PVince81 on 25 Apr 2019

👍2

All 5 comments

ho4ho on 19 Apr 2019

so it seems that renaming "share-" to "shared-" would solve the issue.

however if the icon file name needs to be renamed, it could have an impact on some themes that might use this name, so would consider this a breaking change that needs mentioning in release notes.

cc @pmaier1

PVince81 on 25 Apr 2019

👍2

Thanks for reporting this issue. Just a side note: ABP is not the best adblock solution as you can whitelist addresses if you put in some coins. Better use 'uBlock'. The described issue does not occur with this one ;)