Core: Jewish Calendar Daylight Savings offset?

Created on 12 Apr 2019 · 7Comments · Source: home-assistant/core

Hello,
The Issur Melacha in Effect boolean has been off by an hour ever since daylight savings started. The portion that deals with adding the Jewish calendar is as follows:

sensor:
  - platform: jewish_calendar
    language: english
    diaspora: true
    candle_lighting_minutes_before_sunset: 30
    havdalah_minutes_after_sunset: 45
    sensors:
      - date
      - weekly_portion
      - upcoming_candle_lighting
      - upcoming_havdalah
      - issur_melacha_in_effect

Also, I live in LA if that helps.

jewish_calendar

Source

theChef613

Most helpful comment

Sorry for not commenting earlier. I'm working on a bugfix.
Once I have a patch ready I'll hopefully add it here as a custom component so you don't need to wait for the release.

tsvi on 20 May 2019

👍2

All 7 comments

Hey there @tsvi, mind taking a look at this issue as its been labeled with a integration (jewish_calendar) you are listed as a codeowner for? Thanks!

github-actions[bot] on 12 Apr 2019

I'm having the same issue.

ac2323 on 13 Apr 2019

Hello,
Any update on this? Thank you!

theChef613 on 20 May 2019

Sorry for not commenting earlier. I'm working on a bugfix.
Once I have a patch ready I'll hopefully add it here as a custom component so you don't need to wait for the release.

tsvi on 20 May 2019

👍2

that's great! thank you!

theChef613 on 20 May 2019

hello! I was wondering if there has been any further update on this? I've been using another sensor from the community but that seems to be broken lately too.. :(

theChef613 on 13 Jun 2019

👍1

Mine seems off, but not by an hour. It seems like it might be looking at shkia instead of tzeis for ending times (not sure about the start time)