Core: Raincloud Manual Watering Fails to Activate

[brianhanifin]

Home Assistant release with the issue:
0.92.0dev commit c7a49e0

Last working Home Assistant release (if known):
Possibly unrelated. But perhaps 0.90.0 or 0.91.0? I don't recall.

Operating environment (Hass.io/Docker/Windows/etc.):
Docker on Ubuntu Server

Component/platform:
https://www.home-assistant.io/components/raincloud/

Description of problem:
The switches generated to start a brief watering cycle, no longer start watering. Switching them on, they turn right back off a few a seconds. To be clear I believe they turn off because Home Assistant realizes that it is not in fact on.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

raincloud:
  username: !secret raincloud_username
  password: !secret raincloud_password

sensor:
  - platform: raincloud

binary_sensor:
  - platform: raincloud

switch:
  - platform: raincloud

Traceback (if applicable):

2019-04-07 10:52:20 DEBUG (SyncWorker_1) [homeassistant.components.raincloud.switch] Updating RainCloud switch: Front Yard Manual Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_8) [homeassistant.components.raincloud] Updating RainCloud Hub component

2019-04-07 10:52:23 DEBUG (SyncWorker_4) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor:  Remaining Watering Time

2019-04-07 10:52:23 DEBUG (SyncWorker_0) [homeassistant.components.raincloud.binary_sensor] Updating RainCloud sensor:  Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_3) [homeassistant.components.raincloud.switch] Updating RainCloud switch:  Automatic Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_6) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor: Side Yard Battery

2019-04-07 10:52:23 DEBUG (SyncWorker_3) [homeassistant.components.raincloud.binary_sensor] Updating RainCloud sensor: Pool Filler Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_2) [homeassistant.components.raincloud.switch] Updating RainCloud switch:  Automatic Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_7) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor: Front Yard Next Cycle

2019-04-07 10:52:23 DEBUG (SyncWorker_2) [homeassistant.components.raincloud.binary_sensor] Updating RainCloud sensor: Front Yard Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_1) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor:  Rain Delay

2019-04-07 10:52:23 DEBUG (SyncWorker_0) [homeassistant.components.raincloud.switch] Updating RainCloud switch: Front Yard Manual Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_5) [homeassistant.components.raincloud.binary_sensor] Updating RainCloud sensor: Aquatimer Control Unit Status

2019-04-07 10:52:23 DEBUG (SyncWorker_3) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor:  Remaining Watering Time

2019-04-07 10:52:23 DEBUG (SyncWorker_9) [homeassistant.components.raincloud.binary_sensor] Updating RainCloud sensor: Side Yard Status

2019-04-07 10:52:23 DEBUG (SyncWorker_8) [homeassistant.components.raincloud.switch] Updating RainCloud switch: Pool Filler Manual Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_9) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor:  Rain Delay

2019-04-07 10:52:23 DEBUG (SyncWorker_2) [homeassistant.components.raincloud.binary_sensor] Updating RainCloud sensor:  Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_6) [homeassistant.components.raincloud.switch] Updating RainCloud switch:  Manual Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_0) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor: Pool Filler Rain Delay

2019-04-07 10:52:23 DEBUG (SyncWorker_5) [homeassistant.components.raincloud.switch] Updating RainCloud switch: Pool Filler Automatic Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_3) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor: Pool Filler Remaining Watering Time

2019-04-07 10:52:23 DEBUG (SyncWorker_4) [homeassistant.components.raincloud.switch] Updating RainCloud switch:  Manual Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_1) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor:  Next Cycle

2019-04-07 10:52:23 DEBUG (SyncWorker_1) [homeassistant.components.raincloud.switch] Updating RainCloud switch: Front Yard Automatic Watering

2019-04-07 10:52:23 DEBUG (SyncWorker_2) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor: Front Yard Rain Delay

2019-04-07 10:52:23 DEBUG (SyncWorker_0) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor: Front Yard Remaining Watering Time

2019-04-07 10:52:23 DEBUG (SyncWorker_5) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor: Pool Filler Next Cycle

2019-04-07 10:52:23 DEBUG (SyncWorker_8) [homeassistant.components.raincloud.sensor] Updating RainCloud sensor:  Next Cycle

Additional information:
In the Traceback above you will see a status of "Watering" however, that is for my "Pool Filler" valve, and not the "Front Yard" valve that I am manually attempting to run.

I know a pull request was submitted by @vanstinator to the upstream raincloudy component. While the previous patch allows status reports (and resolved #22422), the manual watering feature now needs some review.

Thank you.

[vanstinator]

Probably related to https://github.com/home-assistant/home-assistant/issues/22422. The changes on Melnors end were fairly significant. I'll take a look at this one.

[vanstinator]

@brianhanifin back when this integration used to work did the manual watering switch turn on if an automated watering cycle was also running? I'm fairly certain I've narrowed down what broke. I just want to make sure it behaves as it previously did before I start submitting PRs again.

[brianhanifin]

@brianhanifin back when this integration used to work did the manual watering switch turn on if an automated watering cycle was also running? I'm fairly certain I've narrowed down what broke. I just want to make sure it behaves as it previously did before I start submitting PRs again.

Hmm. I believe it ignored a manual switch trigger when the watering was already running. In fact I believe triggering the manual watering, when any watering cycle (automatic or manual) was ignored. At least that was my impression.

[vanstinator]

PR has been submitted to the core module. Will pull into HA after it's released to pypi. https://github.com/tchellomello/raincloudy/issues/34