Core: homeassistant-pyozw==0.1.3 fails to install on FreeBSD

[ryanwinter]

Home Assistant release with the issue:
0.91

Last working Home Assistant release (if known):
0.90.2

Operating environment (Hass.io/Docker/Windows/etc.):
FreeBSD

Component/platform:
zwave

Description of problem:
The homeassistant_pyozw fails to install which is a required dependency of home assistant 0.91 for using the zwave component.

b"/tmp/pip-install-owewm927/homeassistant-pyozw/openzwave-embed/open-zwave-hass/cpp/src/command_classes/SensorMultilevel.cpp:502:55: error: adding 'uint8' (aka 'unsigned char') to a string does not append to the string [-Werror,-Wstring-plus-int]\n"

The problem stems from a compilation bug introduced into the homeassistant open-zwave fork here.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
zwave:

[ryanwinter]

I have created a PR to fix.
https://github.com/home-assistant/open-zwave/pull/4

[awarecan]

Same of this? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206526

[ryanwinter]

Same of this? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206526

No, this is different. The bug is specific to the home assistant fork of open-zwave.

[ryanwinter]

Appears to be effecting macosx too:
https://community.home-assistant.io/t/update-ha-to-0-91-zwave-fail/109462/4

[github-actions[bot]]

Hey there @home-assistant/z-wave, mind taking a look at this issue as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

[BazaJayGee66]

Facing similar issue on Raspbian too, with hass version 0.91.1:

[homeassistant.util.package] Unable to install package homeassistant-pyozw==0.1.3: Failed to restore /test/env/lib/python3.5/site-packages/python_openzwave/ozw_config/__pycache__/
Command "/test/env/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-rdc7590c/homeassistant-pyozw/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-zvm5a0u4/install-record.txt --single-version-externally-managed --compile --install-headers /home/home-auto/env/include/site/python3.5/homeassistant-pyozw" failed with error code 1 in /tmp/pip-install-rdc7590c/homeassistant-pyozw/

[ryanwinter]

This bug is blocking a lot of people running z-wave on different platforms, can we have the PR included for 0.91.1?

[robbiet480]

@ryanwinter Just randomly noticed your comment on this flying by in Discord's GitHub channel. Made people aware of this, fix should be coming soon. Assigning @pvizeli as he maintains the fork of OZW that this broke in. Also, cc @clementhk, your PR https://github.com/home-assistant/open-zwave/pull/2 seems to have been either improperly applied to the fork or was later broken for *BSD platforms (specific reports of breakage on FreeBSD and macOS which is BSD at heart).

Does anyone know what the consequences would be of just switching back to mainline OZW? Have there been any associated changes in this (home-assistant/home-assistant) repo that would prevent that? I see a couple of cherry picked items onto the fork and a patch or two, so I'm unsure.

[ryanwinter]

The main line is missing a couple of fixes such as the cover, rolling back would break a bunch of things and make many people unhappy :)

Applying my PR https://github.com/home-assistant/open-zwave/pull/4 fixes the compilation error, would be prefereable to go that route.

[pvizeli]

Is merged with 0.1.4 - Thanks for PR @ryanwinter

[tom-x1]

What does this mean for us? Do we have to upgrade to 0.1.4 or whait for a new HA release?

[pvizeli]

Will be in with 0.92.x

[DallasO]

What does this mean for us? Do we have to upgrade to 0.1.4 or whait for a new HA release?

I downgraded to 0.90.2. Will wait for 0.92.x with the fix for this.

_Using virtualenv install, used command pip3 install --upgrade homeassistant==0.90.2._

[xbtsw]

homeassistant 0.92.0b2 listed homeassistant-pyozw 0.1.4 in requirement. But it still fails installation on raspbian. Is that expected?

[tprelog]

A temporary work around for Home Assistant, you can manually edit zwave/__init__.py to use homeassistant-pyozw==0.1.4 as shown here..

[rschuiling]

I'm wondering, what does it mean the issue was pulled from the 0.91.2 milestone? In what version is this fix planned to be released now?

[bkm-clem]

@rschuiling I believe there is new release from ~2 days ago.

[tprelog]

@rschuiling This has been fixed in the release of HA 92.0