Core: Sizing issue with reply hover card

[gurjyot]

Bug Report

Current Behavior
The reply hover card is not of correct length. I think it shoud be much wider on desktop and not like a vertical card. For the reference, you can also see the issue in the image. To reproduce it, I have provided the steps below.

The hover window is not of the correct size. You can check the thread here. Clarkwinkelmann replied to Ralkage post in another dicussion and when I hover my mouse over the name then this is how the hover card appears.

Steps to Reproduce

1. Go to 'this discussion'
2. Hover on 'clarkwinkelmann name under Ralkage's reply'
3. You'll see the issue there.

Environment

• Website URL: https://discuss.flarum.org
• Browser: Chrome version 71, edge (latest version)
• Operating System: Windows 10 (latest version)

[franzliedke]

I think the iamge says it all.

To be honest, no. Also, images can disappear. I assume you want the card to be wider. What is the "correct" size?

We are thankful for every bug report, but please, never assume anything in bug reports. Provide as much details as possible - optimally in text form - so that it is easy to jump into the topic and understand context even months later.

[gurjyot]

@franzliedke Yes, you are right. Actually, I was in the impression that the bug is small style bug so it won't be long before it's fixed. But I also agree that we should provide as much detail as possible. So I have made some changed in the original post. :)

[franzliedke]

@gurjyot Thanks for your understanding. :wink:

I agree this is a bug and would like to see this fixed, too. I, personally, have some bugs in actual functionality to take care of, so why this is easy to fix, it's not that important in comparison. Good chance for sending a PR, if anyone is interested. :smile:

[SychO9]

Can this be re-opened please ?

For reference:
There was an attempted fix here: https://github.com/flarum/mentions/pull/38
But that introduced another bug which was fixed here: https://github.com/flarum/core/commit/79f90126948a19fe88e405a482f7ce00fffc4b0a
But that reintroduced this bug (:face_with_head_bandage:)

[askvortsov1]

That's unfortunate, I thought that commit hadn't reintroduced the bug. Oh well...

[SychO9]

That's unfortunate, I thought that commit hadn't reintroduced the bug. Oh well...

Indeed, not as simple as I expected, this one'll require more thought into it :thinking:

[askvortsov1]

Hmm, when testing on nightly, I'm not seeing this issue: https://nightly.flarum.site/d/1-testing/5

[SychO9]

you're probably looking at the mention of the post, the issue only happens on the reply preview