Core: IHC manual setup - not working after upgrade til 0.84

Created on 16 Dec 2018 · 25Comments · Source: home-assistant/core

Home Assistant release with the issue:

Last working Home Assistant release (0.83):

Operating environment (Hass.io):

Component/platform:
https://www.home-assistant.io/components/ihc/

Description of problem:

After upgrade manual setup of IHC is not possible - If used with auto_setup: true - lights gets listed...

when using below config - it doesn´t work

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

ihc:
  - url: 'http://192.168.100.90'
    username: !secret ihc_username
    password: !secret ihc_password
    auto_setup: false
    lights:
      - id: 2582109
        name: Spisebord
        dimmable: True
      - id: 3717469
        name: Køkken
        dimmable: True
      - id: 3076189
        name: Entre & Repos
        dimmable: True
      - id: 715613
        name: Vaskerum
        dimmable: True
      - id: 3003997
        name: Stue (TV)
        dimmable: True
      - id: 3902301
        name: Stue (Sofa)
        dimmable: True
      - id: 3103326
        name: Pavillion loft
      - id: 3867998
        name: Gang Kælder
      - id: 4035422
        name: Terrasse væg
    switches:
      - id: 3851612
        name: Entre_1
      - id: 3852124
        name: Entre_3
      - id: 4031580
        name: Sove_1_1
      - id: 4031836
        name: Sove_1_2
      - id: 4032092
        name: Sove_1_3
      - id: 4032348
        name: Sove_1_4
      - id: 4034396
        name: Stueterrasse_1_1
      - id: 4034652
        name: Stueterrasse_1_2
      - id: 4034908
        name: Stueterrasse_1_3
      - id: 4035164
        name: Stueterrasse_1_4
      - id: 4026972
        name: Ringeklokke

Traceback (if applicable):

Additional information:

ihc

Source

ThomasThomsen01

Most helpful comment

I'm currently looking into finding and fixing the bug. Apologize for the inconvenience

Honestly I don't think you should apologize! We are a lot of people here that loved what you are capable of doing, so we can tie it all together in our Home Assistant.
So thank you and thank you for looking into it.

YoinkZed on 17 Dec 2018

👍2

All 25 comments

Please be more explicit. What doesn't work?

MartinHjelmare on 16 Dec 2018

When using the manual setup - no entities are registred, when using auto setup, my lights are registred, but not my switches

ThomasThomsen01 on 17 Dec 2018

Same here. I have manuel setup also, have "migrated" to the new format in configuration.yaml, men no entities are listed.

If i try to validate the file, everything is okay? Could this please be fixed, as right now my whole setup is ruined ?

kentfonager on 17 Dec 2018

I've probably found the bug. These two lines need to be changed to match the config keys for 'sensors', 'lights' etc.

https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/ihc/__init__.py#L212-L213

PR welcome.

MartinHjelmare on 17 Dec 2018

Hi Martin,
Will this be updated automatically with a release, or should I change it myself (same issues when entering lights manually)?

YoinkZed on 17 Dec 2018

Someone needs to make a pull request and fix the bug. When the pull request is merged it will go out in an appropriate release.

MartinHjelmare on 17 Dec 2018

I'm sorry Martin - rookie here, but how can we / I do a pull request?

YoinkZed on 17 Dec 2018

Please read our development docs:
https://developers.home-assistant.io/docs/en/development_index.html

The pull request is further explained in this section:
https://developers.home-assistant.io/docs/en/development_submitting.html

MartinHjelmare on 17 Dec 2018

Thanks man - appreciated!

YoinkZed on 17 Dec 2018

👍2

When can we expect this to be released, as many setups using IHC are broken.

AHuusom on 17 Dec 2018

I'm currently looking into finding and fixing the bug. Apologize for the inconvenience

mopolus on 17 Dec 2018

👍1

I'm currently looking into finding and fixing the bug. Apologize for the inconvenience

YoinkZed on 17 Dec 2018

👍2

The issue is that I used singular in the code and plural in the documentation. In my test I was unfortunately not reading my own documentation 😣.

Can I ask one of you who experience the problem to try out using 'binary_sensor', 'light' and 'switch' instead? Using light, switch and binary_sensor and should work as expected (i.e. work 😉).

I found though a type error for 'sensor' (value for unit of measurement in internal lookup) and will open a PR on that.

I will update the code & documentation but it would be great if any of you can verify that it fixes the issues you see (besides on manual config of sensors).

@MartinHjelmare Using singular would be in line with the old setup. Is there decided on a standard (singular vs plural) for the new?

mopolus on 17 Dec 2018

The issue seems to be that in the code used singular while the documentation used plural. In my test I was unfortunately not reading my own documentation 😣.
Can I ask one of you who experience the problem to try out using 'binary_sensor', 'light', 'sensor', 'switch' instead? I have tested here with light and switch and it works as expected (ie works 😉).
I will update the documentation but it would be great if any of you can verify that it fixes the issues you see.
@MartinHjelmare Using singular would be in line with the old setup. Is there decided on a standard (singular vs plural) for the new?

I can confirm that it works with the 'light' instead of lights. Currently that's the only thing I use,
Thanks man.

YoinkZed on 17 Dec 2018

It also needs to be fixed in the code. Either change the config schema, or change the iteration.

MartinHjelmare on 17 Dec 2018

PR 19415 (and doc update PR 7885) should fix the issues

mopolus on 17 Dec 2018

I can confirm, that both light, switch and binary_sensor is working now, when changing names.

kentfonager on 17 Dec 2018

👍1

@kentfonager i still have problems that my switch and few other things that i created manually in the hass config does not show up, you are stating that it's working now _when changing names_ , what do you mean by that ?

donnib on 20 Dec 2018

There was an error in the documentation and in the schema validation.
If you use "switch" instead of "switches" and "light" instead of "lights" it should work. There is an update comming out with 0.84.4 that will fix the bugs. The names must in any case be updated

mopolus on 20 Dec 2018

@mopolus please update the docs after the fix. 0.84.4 is released.

MartinHjelmare on 20 Dec 2018

@mopolus so like this :

- platform: ihc
  binary_sensor:
  - id: 102674
    name: Knap1_Kip
    inverting: False

and

- platform: ihc
  switch:
    - id: 218718
      name: stue_218718

where i before had binary_sensors and switches.

It's not working for me yet since i guess this fix is in the 0.84.4 and i run 0.84.3 right ? The fix is not out for hass.io yet.

donnib on 20 Dec 2018

No, I've changed the names as suggested and its working now. I have NOT
updated anything. But it seems that 0.84.4 will fix the naming problem with
IHC, if you read the release notes? But right now the newest version for
hass.io is 84.3 i guess ?

On Thu, Dec 20, 2018 at 12:01 PM donnib notifications@github.com wrote:

@mopolus https://github.com/mopolus so like this :

platform: ihc
binary_sensor:

id: 102674

name: Knap1_Kip

inverting: False

and

platform: ihc
switch:

id: 218718

name: stue_218718

where i before had binary_sensors and switches.

It's not working for me yet since i guess this fix is in the 0.84.4 and i
run 0.84.3 right ? The fix is not out for hass.io yet.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/19353#issuecomment-448957579,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOj0DXUgdncg4mWqeRpxBpROBocfIPuks5u624QgaJpZM4ZVVtN
.