Core: Icon doesn't appear in html5 on android

Created on 15 Aug 2018  路  13Comments  路  Source: home-assistant/core

Home Assistant release with the issue:

all of them

Last working Home Assistant release (if known):
all of them

Operating environment (Hass.io/Docker/Windows/etc.):

Component/platform:

Description of problem:
The icon in the Android notification doesn't appear,it is only show a bell icon (the default icon for HA)
This problem related to the google chrome app update, this issue started from Google Chrome Version 68.0
reinstall didn't fixed the issue

35fa672f0f1db3a696a83cfb0dfacab065b2625f_1_614x500

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):


{
"title": "Door",
"message": "Door Opened",
"data": {
"badge": "/local/icons/door_open.png",
"icon": "/local/icons/door.png"
}
}
Traceback (if applicable):


Additional information:

Most helpful comment

Ahah! Everything started working for me today. I thought it was something I did, but upon further investigation, it was in fact a Chrome issue. Last night my phone updated to Chrome Beta 69.0.3497.53. A quick check of the git logs for the release and searching for "badge" turned up this commit:

Fix broken PWA notification badge.

The WebApkServiceClient was overwriting the small icon in the notification builder. This change checks whether there was already a provided small icon bitmap before overwriting.

Looks like the bug was introduced back in May. Glad it has been resolved! We should be able to close this ticket now.
screenshot_20180823-102042

All 13 comments

As I mentioned in #15036, there definitely is a problem with the way that HomeAssistant is sending the notification. You can visit this site and see that a custom badge does indeed work in the latest Chrome.

I get bell icon from Assistant page saved to home screen however if i have chrome open, i get proper HA icon

What do you mean?

I have my ha saved to my android home desktop and it acts like an app(???), so whenever i get html5 notification, it comes from there by default with bell badge. But if i have already open chrome, and get notification, badge is fine. Will post pictures in a while

O.k, i get it,
I will try to do the same and update about the results

So, I was wrong. Actually it seems like step necessary to reproduce this is to get notification WITH and WITHOUT saved page to home screen (for me it acts like some kind of an Assistant app that i needed to uninstall from app drawer). IMHO that saved page or an app takes care of propagation of notifications and has that propagation set up wrong. In pictures, notice origin of these notifications.
With saved page (Assistant app):
screenshot_20180822-154905
Without saved page (now it propages Chrome itself and it is ok):
screenshot_20180822-155347

I'll bet we need to add the icon to the web app manifest.json with the purpose set to badge. See the current App Manifest draft spec: https://www.w3.org/TR/appmanifest/#dom-imageresource-purpose
Not sure if chrome supports this, but makes the most sense for me...

So I hacked the badge into the manifest here https://github.com/home-assistant/home-assistant/blob/7bb53449428b0787cca1d0c986c93a458401e6fb/homeassistant/components/frontend/__init__.py#L45-L63 but it still didn't work. I now wonder if it's a Chrome/Android issue for "apps."

I have tried to dig in the change log of chrome app for android to see what is the change that breaking the icon image, but i don't have a clue

@jawilson, are you sure about that src path? But Im just guessing, to be honest

Ahah! Everything started working for me today. I thought it was something I did, but upon further investigation, it was in fact a Chrome issue. Last night my phone updated to Chrome Beta 69.0.3497.53. A quick check of the git logs for the release and searching for "badge" turned up this commit:

Fix broken PWA notification badge.

The WebApkServiceClient was overwriting the small icon in the notification builder. This change checks whether there was already a provided small icon bitmap before overwriting.

Looks like the bug was introduced back in May. Glad it has been resolved! We should be able to close this ticket now.
screenshot_20180823-102042

Great, Im glad to read that. How long does it usually takes until these fixes are delivered to standard release? Im not fan of beta versions on my cell phone

@tsrubar look like they're aiming for Sept. 4 though apparently Android releases usually lag by a few days.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

piitaya picture piitaya  路  3Comments

YellowMonster76 picture YellowMonster76  路  3Comments

sogeniusio picture sogeniusio  路  3Comments

moskovskiy82 picture moskovskiy82  路  3Comments

arangates picture arangates  路  3Comments