Core: Loading state of Switch is hard to see

Created on 3 Jul 2018 · 4Comments · Source: flarum/core

Bug Report

Current Behavior
After changing a setting using a switch at settings, the loader that warns the user the setting is applying appears over the switch instead of appearing next to it, creating a bad looking UI.

Steps to Reproduce

Go to settings
Click on change one of the options with a switch
See error

Expected Behavior
The loader should appear next to the switch instead of over it.

Screenshots

4765475475

3546635463

Please don't mind the screenshots, I was able to take these even hard because of the speed of Flarum 😉 (the loader was going away immediately)

Environment
Flarum Community
https://discuss.flarum.org

Possible Solution
Move loader next to the switch.

typcleanup

Source

ardacebi

Most helpful comment

Oh wow, I never even noticed that loading indicator.

I was able to take these even hard because of the speed of Flarum :wink:

That must be the reason. :grinning:

Again, this might be intentional, so let's wait for input from @tobscure.

Since I would like to avoid page content jumping around (which might happen with the indicator appearing next to the toggle button), what about adding a semi-transparent overlay to the button while it is saving the state, with the indicator on top? That way, it would be more visible...

franzliedke on 5 Jul 2018

👍2

All 4 comments

Oh wow, I never even noticed that loading indicator.

I was able to take these even hard because of the speed of Flarum :wink:

That must be the reason. :grinning:

Again, this might be intentional, so let's wait for input from @tobscure.

franzliedke on 5 Jul 2018

👍2

@tobscure Do you have anything about this? We've been waiting you for this 🤔

ardacebi on 15 Jul 2018

@TurboProgramming please, I urge you to stop bumping (your own) issues!

I think I speak on behalf of all contributors that every comment is read and seeing these bumps pop up just make me want to press "mark all read", which would be detrimental with all the issues I should know about or where I was mentioned.

This is such a minor issue compared to rewriting the full database schema or pushing forwards with releasing beta 8. Toby was already mentioned and seeing his emoji response he already read it. So .. don't bump please 🙏

luceos on 16 Jul 2018

👍1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!