Core: [Tags] "Start a discussion" button width too small on tags page

Created on 3 Jul 2018  路  9Comments  路  Source: flarum/core

Bug Report

Current Behavior
The "Start a discussion" button collapses for no reason after switching to tags view and opposite.

Steps to Reproduce

  1. Go to homepage
  2. Click on tags
  3. See error

Expected Behavior
"Start a discussion" button should always have the same width.

Screenshots
5785678

354634563645

Environment
Flarum Community
https://discuss.flarum.org

Possible Solution
Disable collapsing and have the same width as the all discussions page on the tags page.

needs-discussion typbug

Most helpful comment

@TurboProgramming Core extension issues are also posted here, but the PRs are made to the corresponding repositories.
Reopen this issue and add [Tags] to the beginning of this issue's title.

All 9 comments

@tobscure It's not, see screenshots (Beta 7) below. This needs to be reopened.

screenshot_2018-07-15 appybuilder community 3


screenshot_2018-07-15 appybuilder community 4

You can see that the button has the same issue even if the alignment issue (#1486) doesn't exist.

@tobscure Do you know which file can I find the code below?

 .TagsPage-nav .item-newDiscussion .Button {
  width:auto
 }

I searched a lot and was not able to find anything for TagsPage.

Do you know which file can I find the code below?

I have the fix and I'm going to open a PR for this, that's why I'm asking.

I found that line of code I sent you via the inspector and it is for the new discussion button on the tags page.

When I try searching that code on the core package, I find one thing: IndexPage.less. That style file is for the new discussion button on the discussion list, not the tags page. It has the exact same code, but TagsPage is replaced with IndexPage.

I don't know how does this exist on the discussion forum, but not in the core code. Just let me know if you find anything about this. I'll apply the fix and open a PR immediately.

The code for the tags extension can be found in this repository.

I keep forgetting that it's an extension thank you 馃憤

This is a core extension issue, closing this.

Please see https://github.com/flarum/flarum-ext-tags/pull/54 for future discussions and updates.

@TurboProgramming Core extension issues are also posted here, but the PRs are made to the corresponding repositories.
Reopen this issue and add [Tags] to the beginning of this issue's title.

Was this page helpful?
0 / 5 - 0 ratings