Core: Side nav does not collapse early enough on tags page

[ardacebi]

Bug Report

Current Behavior
"All Discussions", "Tags" etc. buttons don't collapse and use a lot of unnecessary space while viewing only the tags.

Steps to Reproduce

1. Go to homepage
2. Click on tags
3. See error

Expected Behavior
The buttons should horizontally align to save space for sub-tags hiding at the bottom.

Screenshots

Environment
Flarum Community
https://discuss.flarum.org

Possible Solution
Align the "All Discussions", "Tags" etc. buttons horizontally to save space.

[franzliedke]

I am thinking the problem is that these media queries do not match up:

• https://github.com/flarum/flarum-ext-tags/blob/03613432cb5e944c6387f1a652942dbbe5713370/less/forum.less#L33
• https://github.com/flarum/flarum-ext-tags/blob/03613432cb5e944c6387f1a652942dbbe5713370/less/forum.less#L57
• https://github.com/flarum/core/blob/00bc8fc0bc63643ec850f5d5eec78701225b7f7b/less/common/sideNav.less#L91

Again, let's wait for input from Toby.

[ardacebi]

@franzliedke What about this: https://github.com/flarum/core/issues/1487?
This seems to be a related issue with that.

[franzliedke]

@TurboProgramming No need to tag us, we get notifications for all these issues anyway. Toby is currently away, he will respond in due time.

[ardacebi]

I tested this with Flarum Beta 7 and this bug does not exist.

This is a bug introduced now and only applies for the dev channel. Did you apply any changes regarding this area that might produce this kind of bug?

[franzliedke]

It's very likely due to this commit:
https://github.com/flarum/core/commit/2754a8c8671a404a3d69bc80cf45d7e99559052c

[ardacebi]

So what should we do to bring this back?

[franzliedke]

You can

• either wait for some input from Toby, or
• investigate the changes, try them out and see which part of the change caused the bug.

[tobyzerner]

Slating this for beta 8 as it's a regression (and a pretty glaring one at that!)

[tobyzerner]

Fixed in https://github.com/flarum/core/commit/7b802a76ba0f5c61b8720a839a37580cfe4e71d5