Core: Deprecation notices with SensioFrameworkExtraBundle 5.2

Created on 30 Jun 2018  路  5Comments  路  Source: api-platform/core

Changelog:
https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/CHANGELOG.md

Also replace the annotations Sensio\Bundle\FrameworkExtraBundle\Configuration\Route and Sensio\Bundle\FrameworkExtraBundle\Configuration\Method with Symfony\Component\Routing\Annotation\Route

Seems it needs to be changed in:

  • core/tests/Fixtures/TestBundle/Controller/CustomActionController.php
  • core/tests/Fixtures/TestBundle/Controller/DummyValidationController.php

to avoid deprecation notices during testing

easy pick help wanted

Most helpful comment

I think we should test with 5.x too, as that's the latest stable.

All 5 comments

Good catch. Do you want to send a PR for it? :)

I rather not at the moment. I am not sure if it is just changing the class name or that it could be more complex and that it might break something (e.g. the tests).

Our version constraint is ^4.0 so we shouldn't reach 5.0 in the core, especially that these are only present in our tests. As it's not used anywhere else there really is no rush here.

I think we should test with 5.x too, as that's the latest stable.

Done in #2108 @nielsvandermolen Thanks for reporting

Was this page helpful?
0 / 5 - 0 ratings

Related issues

desmax picture desmax  路  3Comments

kate-kate picture kate-kate  路  3Comments

silverbackdan picture silverbackdan  路  3Comments

rockyweng picture rockyweng  路  3Comments

lukasluecke picture lukasluecke  路  3Comments