Core: [b8] CommentPost article has undefined class

Created on 12 Jun 2018  路  5Comments  路  Source: flarum/core

image

https://discuss.flarum.org/d/12942-shared-hosting/11

typbug
Source
picture luceos

Most helpful comment

I'd like to do that, as @tobscure mentioned, there might be similar problem in other components. I'll look around.

picture sijad on 12 Jun 2018
👍2

All 5 comments

There are probably a bunch of these in other components around the place too.

tobyzerner picture tobyzerner on 12 Jun 2018

It really doesn't make much sense because both the CommentPost and Post components have fallbacks to '': className || ''

https://github.com/flarum/core/blob/211e7681ccd53a8fe408946c380b663f0dfb3301/js/forum/src/components/Post.js#L42

luceos picture luceos on 12 Jun 2018
😕2

@luceos i guess problem was here:

https://github.com/flarum/core/blob/211e7681ccd53a8fe408946c380b663f0dfb3301/js/forum/src/components/CommentPost.js#L83

sijad picture sijad on 12 Jun 2018

@sijad correct; might need a PR. Someone up for it?

luceos picture luceos on 12 Jun 2018

I'd like to do that, as @tobscure mentioned, there might be similar problem in other components. I'll look around.

sijad picture sijad on 12 Jun 2018
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

KitsuneSolar picture KitsuneSolar  路  54Comments
jordanjay29 picture jordanjay29  路  29Comments
tobyzerner picture tobyzerner  路  55Comments
luceos picture luceos  路  33Comments
tobyzerner picture tobyzerner  路  27Comments