Core: Send mail notification for shared files breaks if Collaborative Tags-App is disabled

[felixheidecke]

Steps to reproduce

1. Disable _Collaborative tags_ in the apps section
2. Enable _"Allow users to send mail notification for shared files"_ in sharing settings
3. Create a public link share

Expected behaviour

Modal should should show sharing-form

Actual behaviour

Empty modal opens

Server configuration

Operating system:
any
Web server:
any
Database:
any
PHP version:
any
ownCloud version: (see ownCloud admin page)
10.0.8

Problem

select2 lib is provided by the Collaborative Tags-App and used in the mail notification process.

Javascript console log

this.$el.find(...).select2 is not a function

[ownclouders]

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are https://github.com/owncloud/core/issues/9770 (Disable "Share files" breaks files app), https://github.com/owncloud/core/issues/4499 (Shared File Notifications), https://github.com/owncloud/core/issues/12608 (Shared file notifications), https://github.com/owncloud/core/issues/3465 (Sharing files), and https://github.com/owncloud/core/issues/17829 (Disabling and re-enabling file sharing breaks files app).

[phil-davis]

@patrickjahns @individual-it this is where it will be good to have a test matrix that runs all the API and webUI acceptance tests with different combinations of apps disabled/enabled.

e.g. a first cut would be to disable all core-bundled apps that are possible for sysadmins to disable. Then let all the tests run (except of course tests specific to the disabled apps), and see what happens.

[felixboehm]

Please add a test to ensure we will not have regressions.

[individual-it]

@phil-davis opened an issue for this kind of tests https://github.com/owncloud/QA/issues/561

[PVince81]

This was already reported to us here https://github.com/owncloud/core/issues/31454 and also more people told me directly.

Increasing to p2 as release blocker for next release.

[PVince81]

leaving open until backport is done

[PVince81]

will be released in 10.0.9 (next release)

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.