Core: [10.0.8 RC1] Public link share dialog

[pmaier1]

• [ ] Size of the modal itself may not change when multiple (long) mail addresses are entered (it even changes when selecting the input field and selecting another item in the dialog)
• [ ] Move "Share" button to the right, "Cancel" to the left. The current order seems not intuitive.
• [ ] E-mail validation should be added (currently select2 takes all values; you can even just enter spaces): [email protected]

• [ ] Multiple mail recipients should not be able to see the other recipient's mail addresses. Therefore we should not put all mail addresses in the "To" field but in "BCC". @PVince81

• [ ] "Send copy to self" does not work at all (mails are only sent to the recipients). No ability to receive a copy, tried various scenarios. @PVince81

• [ ] "E-Mail sent" has been removed. It was an explicit requirement to show "E-Mail sent" longer for that the user actually has a chance to read it.
• [ ] Public link sendmail: "Sending" is now green, but the actual idea was to have the success message "E-Mail sent" green (which has been removed!)
• [ ] "Sending" now seems to have a delay of 2 seconds until it disappears. This was the idea for the "E-Mail sent" indicator.
• [ ] Look into https://github.com/owncloud/core/pull/29935#issuecomment-381095714. Should be covered with email validation anyway.

Tested with Firefox 59 / Ubuntu 17.10

Adding long/many mail address(es) (modal size increases)

Unselect the input field (modal size shrinks)

@PVince81

[ownclouders]

GitMate.io thinks possibly related issues are https://github.com/owncloud/core/pull/31083 (Update changelog in preparation for 10.0.8 RC1), https://github.com/owncloud/core/issues/23611 (8.2 to 9.0 : Lost calendar share), https://github.com/owncloud/core/issues/22735 (CalDAV: support public sharing), https://github.com/owncloud/core/issues/28451 (Validate email before sending out public link from dialog), and https://github.com/owncloud/core/issues/6110 (in Share dialog).

[felixheidecke]

Hmm … this is weird because it shouldn't grow and I did add a validator that checks the email syntax … I hope nothing got lost while I recovered that feature since it was considered canceled at one state.

I'll have a look at it.

[felixheidecke]

Japp, something did break there … :-|

[felixheidecke]

This PR takes care of the problems.

[pmaier1]

Can we also change the wording "Send copy to self" to "Receive a copy" or similar, please?

[pmaier1]

Added

• Multiple mail recipients should not be able to see the other recipient's mail addresses. Therefore we should not put all mail addresses in the "To" field but to "BCC".

[pmaier1]

Added

• "Send copy to self" does not work at all (mails are only sent to the recipients). No ability to receive a copy, tried various scenarios.
• "E-Mail sent" has been removed. It was an explicit requirement to show "E-Mail sent" longer for that the user actually has a chance to read it.
• Public link sendmail: "Sending" is now green, but the actual idea was to have the success message "E-Mail sent" green (which has been removed!)
• "Sending" now seems to have a delay of 2 seconds until it disappears. This was the idea for the "E-Mail sent" indicator.

[felixheidecke]

@PVince81 @pmaier1 we need a PHP dev attending to PHP related issues here.

[PVince81]

I'll have a look at the PHP part

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.